Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL] cleanup javascript in repo #2870

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

TimothyMothra
Copy link
Member

@TimothyMothra TimothyMothra commented Apr 24, 2024

CodeQL detected Javascript in our repo.
The only Javascript I could find was in some test apps.
As we don't ship any javascript from this repo, I'm attempting to remove all Javascript to get CodeQL to pass.

Changes

  • enable Javascript scanning in CodeQL workflow
  • delete "NETCORE/test/FunctionalTests.MVC.Tests/wwwroot/" directory. This contains CSS, SVG, and JS files which are not needed for our unit tests

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@TimothyMothra TimothyMothra marked this pull request as ready for review April 24, 2024 17:10
@TimothyMothra TimothyMothra changed the title cleanup javascript in repo [SDL] cleanup javascript in repo Apr 24, 2024
@TimothyMothra TimothyMothra merged commit 99118c9 into main Apr 24, 2024
74 checks passed
@TimothyMothra TimothyMothra deleted the tilee/cleanup_javascript branch April 24, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants