Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove braces while serializing {OriginalFormat} #2362

Merged
merged 3 commits into from
Aug 13, 2021

Conversation

reyang
Copy link
Member

@reyang reyang commented Aug 12, 2021

Similar to #2071.

The following code would cause a key-value pair in the property bag with the key equals to {OriginalFormat}.

image

            Application Insights Telemetry: 
            {
              "name":"AppTraces",
              "time":"2021-04-22T22:41:50.4529345Z",
              "iKey":"--YourAIKeyHere--",
              "tags":{
                "ai.application.ver":"1.0.0.0",
                "ai.cloud.roleInstance":"-------------",
                "ai.internal.sdkVersion":"il:2.17.0-146",
                "ai.internal.nodeName":"----------"
              },
              "data":{
                "baseType":"MessageData",
                "baseData":{
                  "ver":2,
                  "message":"Test application is starting",
                  "severityLevel":"Information",
                  "properties":{
                    "AspNetCoreEnvironment":"Development",
                    "DeveloperMode":"true",
                    "CategoryName":"AppInsightsScopeTest.TestApplication",
                                            "{OriginalFormat}":"TestScope {ScopeColumn1} and {ScopeColumn2}",    <----- !!! THIS IS WHAT PROBABLY BREAKS KUSTO !!!
                    "OriginalFormat":"Test application is starting",
                    "ScopeColumn2":"5678",
                    "ScopeColumn1":"1234"
                  }
                }
              }
            }

@TimothyMothra TimothyMothra added this to the 2.19 milestone Aug 12, 2021
@TimothyMothra
Copy link
Member

LGTM. Should we add any unit tests?

@reyang
Copy link
Member Author

reyang commented Aug 13, 2021

LGTM. Should we add any unit tests?

I've added unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants