add support for Net462 #2277
Closed
add support for Net462 #2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pharring
reviewed
May 24, 2021
BASE/src/ServerTelemetryChannel/Implementation/ApplicationFolderProvider.cs
Outdated
Show resolved
Hide resolved
pharring
reviewed
May 24, 2021
...icationInsights/Extensibility/Implementation/Tracing/BaseDefaultHeartbeatPropertyProvider.cs
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
cijothomas
reviewed
May 24, 2021
BASE/src/Microsoft.ApplicationInsights/Microsoft.ApplicationInsights.csproj
Show resolved
Hide resolved
4 tasks
| @@ -2,7 +2,7 @@ | |||
| <Import Project="$(PropsRoot)\Product.props" /> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>net452</TargetFrameworks> | |||
| <TargetFrameworks>net452;net462</TargetFrameworks> | |||
There was a problem hiding this comment.
Adding net462 might force us to support this project Microsoft.ApplicationInsights.EtwCollector for a long time. Should we reconsider adding net462 to this project?
There was a problem hiding this comment.
I agree with you, but I was reluctant to make that decision.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future Proof related to #2273.
Helping to support AAD work #2190.
Changes
Checklist
For significant contributions please make sure you have completed the following items:
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build