ApplicationInsights logging in NLog and log4net should include ExceptionTelemetry.Message #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cijothomas
approved these changes
Nov 19, 2019
cijothomas
reviewed
Nov 19, 2019
LOGGING/test/Log4NetAppender.Net45.Tests/ApplicationInsightsAppenderTests.cs
Outdated
Show resolved
Hide resolved
Done |
|
@snakefoot Can you please update I'm sorry for the inconvenience and I've removed the older Changelogs to eliminate this confusion. These were left over from the repo migration. This is our final ask and I'm ready to merge this now. |
…ionTelemetry.Message
…ionTelemetry.Message (Code review)
Done |
…ionTelemetry.Message (ChangeLog)
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
TimothyMothra
approved these changes
Nov 21, 2019
|
/AzurePipelines run AI-DotNetSDK-Gated+REORG(Everything) |
|
@snakefoot We published 2.12-Beta4 this morning including your changes! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-breaking change for log4net and NLog.
Will improve this screenshot to include Message-details for Exceptions: