Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for collecting Track 2 Azure SDK client activities #1300

Merged
merged 14 commits into from
Nov 22, 2019
Merged

Add support for collecting Track 2 Azure SDK client activities #1300

merged 14 commits into from
Nov 22, 2019

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Nov 13, 2019

@pakrym
Copy link
Contributor Author

pakrym commented Nov 14, 2019

Output from my sample app:

image

@lmolkova
Copy link
Member

lmolkova commented Nov 14, 2019 •
edited
Loading

Looking into the screenshot, there are several things we need to fix:

  1. HTTP requests - we need to dedup double-instrumentation for HTTP from azure SDK and in AppInsights. In existing listeners (for core and desktop), we should back-off if traceparent header is present.

  2. Dependency types: OTHER and properties - we'll need to fix them.

  • EventHub processor should be request-telemetry (not dependency) All server span should translate into requests
  • Internal spans (convenience layer) should be dependency telemetry with kind InProc
  • Client spans should translate into Dependency with the appropriate type. EventHubs is the only SDK that emits such spans now and properties on the dependency should match what we report for existing EventHub (Track1) SDK in the existing eventhub listener. It includes dependency type, data and target.

I can help with this.

@pakrym
Copy link
Contributor Author

pakrym commented Nov 14, 2019

I can help with this.

I would appreciate the help.

@lmolkova lmolkova mentioned this pull request Nov 20, 2019
Merged
3 tasks
lmolkova
lmolkova approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cijothomas can you have a look?
I'd like to merge it by EOD tomorrow if there are no objections.

@lmolkova lmolkova closed this Nov 21, 2019
@lmolkova lmolkova reopened this Nov 21, 2019
@lmolkova
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lmolkova
Copy link
Member

@pakrym can you please also update changelog

@pakrym
Copy link
Contributor Author

pakrym commented Nov 21, 2019

@pakrym can you please also update changelog

Done

@lmolkova
Copy link
Member

@pakrym please also merge pakrym#2 - I broke some tests....

@pakrym
Copy link
Contributor Author

pakrym commented Nov 21, 2019

@pakrym please also merge pakrym#2 - I broke some tests....

Done

@lmolkova
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lmolkova
Copy link
Member

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lmolkova
Copy link
Member

last call for comments. Going to merge in 2 hours.

@lmolkova lmolkova merged commit d94ee82 into microsoft:develop Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas left review comments

@lmolkova lmolkova lmolkova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pakrym @lmolkova @cijothomas