Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial sampling rate from applicationHost.config fix #1048

Merged
merged 19 commits into from
Jan 10, 2019
Merged

Initial sampling rate from applicationHost.config fix #1048

merged 19 commits into from
Jan 10, 2019

Conversation

Mikhail-msft
Copy link
Contributor

@Mikhail-msft Mikhail-msft commented Jan 9, 2019 •
edited
Loading

Fix of an InitialSamplingRate, when setting it through the applicationHost.config would not apply it.
Also resolves #926.

For significant contributions please make sure you have completed the following items:

  • [] Design discussion issue #
  • Changes in public surface reviewed
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
  • The PR will trigger build, unit test, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.

cijothomas and others added 17 commits November 20, 2018 14:14
@cijothomas
Merge pull request #1015 from Microsoft/develop
ec386a2 
dev to master 29 beta2
@oco27
Fix a typo in a method name
5537a63
@Dmitry-Matveev
Intiail implementation of IExtension and unknown ITelemetry support i…
712982a 
…n RichPayloadEventSource
@Dmitry-Matveev
Changelog update
857e0da
@Dmitry-Matveev
Update PR link
bc32aae
@pharring
Add test to cover ETW payload serialization
e6dee56
@TimothyMothra
add postbuild targets (#1020)
ef19c76
Fix: Start/StopOperation does not work when W3C is enabled (#1031)
a2cfe6e 
* Fix: Start/StopOperation does not work when W3C is enabled

* build and changelog
@TimothyMothra
Update ExteptionTelemetry class summary (#1032)
1dc2fb4 
Customer asked if we log Exception.Data.
This was not clear from our documentation.
@macrogreg
Metrics: Use dedicated thread instead of the thread pool for the defa… (
43feef1 
#1028)

* Metrics: Use dedicated thread instead of the thread pool for the default aggregation cycle (code only, does not build not NetStandard).

* Add missing reference to System.Threading.Thread on netstandard1.3

* changelog
Change version to 2.9.0-beta3 (#1038)
1bb2477
sync
83f188e
UTs
5cf1acf
changelog update
b639c49
merge develop
e2c89c4
in-code doc update
7bb975b
doc fix
7c22c9d
@SergeyKanzhelev
Copy link
Contributor

SergeyKanzhelev commented Jan 9, 2019 •
edited
Loading

Does it address #926 as well? If not - can you please include that fix as well.

@Mikhail-msft
Copy link
Contributor Author

Mikhail-msft commented Jan 9, 2019 •
edited
Loading

Does it address #926 as well? If not - can you please include that fix as well.

@SergeyKanzhelev, I cannot repro the issue you mentioned using latest develop bits. Do you have more details on the repro steps?

@Mikhail-msft
Copy link
Contributor Author

Does it address #926 as well? If not - can you please include that fix as well.

@SergeyKanzhelev, I cannot repro the issue you mentioned using latest develop bits. Do you have more details on the repro steps?

The issue was that inner SamplingTelemetryProcessor did not have the SamplingPercentage set to initial value. This is now fixed. Note changing behavior of Min-Max vs InitialSamplingPercentage is out of scope of this PR.

@Mikhail-msft Mikhail-msft reopened this Jan 10, 2019
SergeyKanzhelev
SergeyKanzhelev approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing an additional issue. Please allow others to review as well

@SergeyKanzhelev
Copy link
Contributor

Note changing behavior of Min-Max vs InitialSamplingPercentage is out of scope of this PR.

Can you please make a remark in issue I referred to explaining what is fixed and what is not. Or create a separate one

@Mikhail-msft Mikhail-msft reopened this Jan 10, 2019
@Mikhail-msft Mikhail-msft merged commit 6b70c45 into develop Jan 10, 2019
@Mikhail-msft Mikhail-msft deleted the mikp/InitialSamplingRateFix branch January 10, 2019 01:29
@renovate renovate bot mentioned this pull request Jun 6, 2021
Closed
1 task
@renovate renovate bot mentioned this pull request Dec 12, 2021
Merged
1 task
This was referenced May 19, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AdaptiveSamplingProcessor constructor doesn't respect arguments passed
8 participants
@Mikhail-msft @SergeyKanzhelev @cijothomas @oco27 @Dmitry-Matveev @pharring @TimothyMothra @macrogreg