Skip to content

Bug: Both TelemetryChannels do not correctly handle AggregateException #1173

Closed

Description

If you are reporting bug/issue, please provide detailed Repro instructions.

Repro Steps

still investigating, don't have a repro yet

Breeze fixed their issues. Can test using this: https://badssl.com/

Actual Behavior

We aren't handling the AggregateException.
Instead, we log this message:

"Failed to send: One or more errors occurred.."

try
{
// send request
this.Send(telemetryItems, timeout).Wait();
}
catch (Exception e)
{
CoreEventSource.Log.FailedToSend(e.Message);
}

Send method returns a Task

private Task Send(IEnumerable<ITelemetry> telemetryItems, TimeSpan timeout)

Expected Behavior

We need to correctly handle the AggregateException.

Version Info

SDK Version : all
.NET Version : all
How Application was onboarded with SDK(VisualStudio/StatusMonitor/Azure Extension) :
OS : nuget
Hosting Info (IIS/Azure WebApps/ etc) : onprem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions