Use appropriate namespace for NoOpTelemetryModule. (#2442)

* Use appropriate namespace for NoOpTelemetryModule. The Shared.Implementation namespace causes compile errors for any project that references the Microsoft.ApplicationInsights.AspNetCore package and has a type named Shared. * Update changelog for NoOpTelemetryModule namespace change. * Update CHANGELOG.md Co-authored-by: Cijo Thomas <cithomas@microsoft.com> Co-authored-by: Timothy Mothra <tilee@microsoft.com>
microsoft · May 11, 2022 · b9733c9 · b9733c9
1 parent 5aed71e
commit b9733c9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## VNext
 - [LOGGING: Make TelemetryConfiguration configurable in ApplicationInsightsLoggingBuilderExtensions](https://github.com/microsoft/ApplicationInsights-dotnet/issues/1944)
 - [Added support for distributed tracing with Azure.Messaging.ServiceBus](https://github.com/microsoft/ApplicationInsights-dotnet/pull/2593)
+- [Move internal type from `Shared` to `Microsoft` namespace](https://github.com/microsoft/ApplicationInsights-dotnet/pull/2442)
 
 ## Version 2.21.0-beta1
 - [Support IPv6 in request headers](https://github.com/microsoft/ApplicationInsights-dotnet/issues/2521)

diff --git a/.../src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs b/.../src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs
@@ -15,7 +15,6 @@
     using Microsoft.Extensions.Configuration;
     using Microsoft.Extensions.DependencyInjection.Extensions;
     using Microsoft.Extensions.Options;
-    using Shared.Implementation;
 
     /// <summary>
     /// Extension methods for <see cref="IServiceCollection"/> that allow adding Application Insights services to application.

diff --git a/NETCORE/src/Shared/Extensions/ApplicationInsightsExtensions.cs b/NETCORE/src/Shared/Extensions/ApplicationInsightsExtensions.cs
@@ -39,8 +39,6 @@
     using Microsoft.Extensions.Logging;
     using Microsoft.Extensions.Options;
 
-    using Shared.Implementation;
-
     /// <summary>
     /// Extension methods for <see cref="IServiceCollection"/> that allow adding Application Insights services to application.
     /// </summary>

diff --git a/NETCORE/src/Shared/Implementation/NoOpTelemetryModule.cs b/NETCORE/src/Shared/Implementation/NoOpTelemetryModule.cs
@@ -1,4 +1,8 @@
-namespace Shared.Implementation
+#if AI_ASPNETCORE_WEB
+    namespace Microsoft.ApplicationInsights.AspNetCore
+#else
+    namespace Microsoft.ApplicationInsights.WorkerService
+#endif
 {
     using System.Diagnostics.CodeAnalysis;
     using Microsoft.ApplicationInsights.Extensibility;