This repository has been archived by the owner on Jul 5, 2020. It is now read-only.
Update Microsoft.AspNet.TelemetryCorrelation to latest version #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
lmolkova/UpdateAspNetTelemetryCorrelation
branch
from
9159556
to
ef76575
Compare
lmolkova
force-pushed
the
lmolkova/UpdateAspNetTelemetryCorrelation
branch
from
ef76575
to
68530a2
Compare
SergeyKanzhelev
approved these changes
Apr 10, 2018
| @@ -37,6 +37,10 @@ | |||
| <assemblyIdentity name="WebGrease" culture="neutral" publicKeyToken="31bf3856ad364e35" /> | |||
| <bindingRedirect oldVersion="0.0.0.0-1.5.2.14234" newVersion="1.5.2.14234" /> | |||
| </dependentAssembly> | |||
| <dependentAssembly> | |||
| <assemblyIdentity name="Microsoft.AspNet.TelemetryCorrelation" publicKeyToken="31bf3856ad364e35" culture="neutral" /> | |||
| <bindingRedirect oldVersion="0.0.0.0-1.0.1.0" newVersion="1.0.1.0" /> | |||
There was a problem hiding this comment.
you don't need binding redirect, do you?
There was a problem hiding this comment.
No, but VS would add them anyway when you update the package.
TimothyMothra
approved these changes
Apr 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version (1.0.1) fixes critical issue aspnet/Microsoft.AspNet.TelemetryCorrelation#22 when Activity with broken parent stack could never be stopped and request tracking hangs.
For significant contributions please make sure you have completed the following items:
Changes in public surface reviewed
Design discussion issue #
CHANGELOG.md updated with one line description of the fix, and a link to the original issue.
The PR will trigger build, unit tests, and functional tests automatically. If your PR was submitted from fork - mention one of committers to initiate the build for you.
If you want to to re-run the build/tests, the easiest way is to simply Close and Re-Open this same PR. (Just click 'close pull request' followed by 'open pull request' buttons at the bottom of the PR)
Please follow [these] (https://github.com/Microsoft/ApplicationInsights-dotnet-server/blob/develop/CONTRIBUTING.md) instructions to build and test locally.