This repository has been archived by the owner on Jul 5, 2020. It is now read-only.
Ignore Deprecated events if running under netcore20 #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewer events. Issue 723
|
@lmolkova i was playing with this and ended up with this! Can you see if this is the fix indeed? |
lmolkova
reviewed
Nov 3, 2017
| @@ -66,6 +69,9 @@ internal class HttpCoreDiagnosticSourceListener : IObserver<KeyValuePair<string, | |||
| this.client = new TelemetryClient(configuration); | |||
| this.client.Context.GetInternalContext().SdkVersion = SdkVersionUtils.GetSdkVersion("rdd" + RddSource.DiagnosticSourceCore + ":"); | |||
|
|
|||
| var httpClientVersion = typeof(HttpClient).GetTypeInfo().Assembly.GetName().Version; | |||
| this.isNetCore20HttpClient = httpClientVersion.CompareTo(new Version(4, 2)) >= 0; | |||
There was a problem hiding this comment.
perhaps you can also remove this code from subscriber and pass isNetCore20HttpClient to subscriber's constructor
There was a problem hiding this comment.
right.. less code duplication :)
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore Deprecated events if running under netcore20 as it publishes newer events.
Attempt to fix #723