This repository has been archived by the owner on Jul 5, 2020. It is now read-only.
[2.11.0-beta1] guard against malicious headers in quickpulse #1191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
suggested changes
May 21, 2019
…/Microsoft/ApplicationInsights-dotnet-server into tilee/quickpulse_protect_headers
TimothyMothra
changed the title
TimothyMothra
changed the title
|
@cijothomas is it safe to merge this now? :) |
cijothomas
approved these changes
Jun 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1: Cijo please review
In a previous SDL we introduced
InjectionGuardConstantsto protect from malicious values being injected into the SDK and causing memory overruns.I found a place in QuickPulse not doing this check.
(For reference see, mseng bug 651018)
Part 2: Alex please review
QuickPulseServiceClientwas retrieving an array of request headers but only using the First() value.I didn't want to do a length check on an entire array if only the first value would be used.
I changed the implementation to only return the first element in an array.