This repository has been archived by the owner on Jul 5, 2020. It is now read-only.
This repository has been archived by the owner on Jul 5, 2020. It is now read-only.
Check for null serviceClient when disposing QuickPulseTelemetryModule. #1169
Closed
Description
openedon Apr 12, 2019
To get around #1168, we had plans to delay the call to QuickPulseTelemetryModule.Initialize() by 15 seconds. But we found that if the site was being shut down before those 15 seconds had expired, we'd get a NullRef. I'm guessing it's b/c of the missing null-check on serviceClient here: https://github.com/Microsoft/ApplicationInsights-dotnet-server/blob/develop/Src/PerformanceCollector/Perf.Shared/QuickPulseTelemetryModule.cs#L700.
/cc @lmolkova
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Metadata
Assignees
Labels
No labels