This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix failing unit tests #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyKanzhelev
approved these changes
Apr 14, 2018
|
@pharring Thank you for working on the weekend to un-block us!! |
|
The webhook isn't triggering the build for this PR, but I ran it manually and it passed all the tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173
I reverted my changes to AdapterHelper. The key thing is NOT to set TelemetryConfiguration.Active.InstrumentationKey there.
That fixed the failing EventSourceTelemetryModule test. To be honest, I have no idea why.
However, it broke two others. So I fixed those by manually setting TelemetryConfiguration.Active.InstrumentationKey.