review comments

microsoft · Aug 21, 2018 · 8140ff1 · 8140ff1
1 parent 190b57f
commit 8140ff1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/...cationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs b/...cationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs
@@ -307,9 +307,9 @@ private RequestTelemetry InitializeRequestTelemetry(HttpContext httpContext, Act
 
             foreach (var prop in activity.Baggage)
             {
-                if (!requestTelemetry.Context.Properties.ContainsKey(prop.Key))
+                if (!requestTelemetry.Properties.ContainsKey(prop.Key))
                 {
-                    requestTelemetry.Context.Properties[prop.Key] = prop.Value;
+                    requestTelemetry.Properties[prop.Key] = prop.Value;
                 }
             }
 

diff --git a/src/Microsoft.ApplicationInsights.AspNetCore/Microsoft.ApplicationInsights.AspNetCore.csproj b/src/Microsoft.ApplicationInsights.AspNetCore/Microsoft.ApplicationInsights.AspNetCore.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
     <AssemblyName>Microsoft.ApplicationInsights.AspNetCore</AssemblyName>
-    <VersionPrefix>2.4.1</VersionPrefix>
+    <VersionPrefix>2.5.0-beta1</VersionPrefix>
     <Authors>Microsoft</Authors>
     <Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
     <AssemblyTitle>Application Insights for ASP.NET Core Web Applications</AssemblyTitle>

diff --git a/test/Microsoft.ApplicationInsights.AspNetCore.Tests/RequestTrackingMiddlewareTest.cs b/test/Microsoft.ApplicationInsights.AspNetCore.Tests/RequestTrackingMiddlewareTest.cs
@@ -590,7 +590,7 @@ public void DoesntAddSourceIfRequestHeadersDontHaveSource()
 
         #pragma warning disable 612, 618
         [Fact]
-        public void OnHttpRequestInStartWithW3CHeadersIsTrackedCorrectly()
+        public void OnBeginRequestWithW3CHeadersIsTrackedCorrectly()
         {
             var configuration = TelemetryConfiguration.CreateDefault();
             configuration.TelemetryInitializers.Add(new W3COperationCorrelationTelemetryInitializer());
@@ -649,7 +649,7 @@ public void OnHttpRequestInStartWithW3CHeadersIsTrackedCorrectly()
         }
 
         [Fact]
-        public void OnHttpRequestInStartWithW3CHeadersAndRequestIdIsTrackedCorrectly()
+        public void OnBeginRequestWithW3CHeadersAndRequestIdIsTrackedCorrectly()
         {
             var configuration = TelemetryConfiguration.CreateDefault();
             configuration.TelemetryInitializers.Add(new W3COperationCorrelationTelemetryInitializer());
@@ -694,7 +694,7 @@ public void OnHttpRequestInStartWithW3CHeadersAndRequestIdIsTrackedCorrectly()
         }
 
         [Fact]
-        public void OnHttpRequestInStartWithNoW3CHeadersAndRequestIdIsTrackedCorrectly()
+        public void OnBeginRequestWithNoW3CHeadersAndRequestIdIsTrackedCorrectly()
         {
             var configuration = TelemetryConfiguration.CreateDefault();
             configuration.TelemetryInitializers.Add(new W3COperationCorrelationTelemetryInitializer());
@@ -728,7 +728,7 @@ public void OnHttpRequestInStartWithNoW3CHeadersAndRequestIdIsTrackedCorrectly()
         }
 
         [Fact]
-        public void OnHttpRequestInStartWithW3CSupportAndNoHeadersIsTrackedCorrectly()
+        public void OnBeginRequestWithW3CSupportAndNoHeadersIsTrackedCorrectly()
         {
             var configuration = TelemetryConfiguration.CreateDefault();
             configuration.TelemetryInitializers.Add(new W3COperationCorrelationTelemetryInitializer());
@@ -767,7 +767,7 @@ public void OnHttpRequestInStartWithW3CSupportAndNoHeadersIsTrackedCorrectly()
         }
 
         [Fact]
-        public void OnHttpRequestInStartWithW3CHeadersAndAppIdInState()
+        public void OnBeginRequestWithW3CHeadersAndAppIdInState()
         {
             var configuration = TelemetryConfiguration.CreateDefault();
             configuration.TelemetryInitializers.Add(new W3COperationCorrelationTelemetryInitializer());