PR Comments

src/Microsoft.ApplicationInsights.AspNetCore/Extensions/ApplicationInsightsExtensions.cs

@@ -160,7 +160,7 @@ public static IServiceCollection AddApplicationInsightsTelemetry(this IServiceCo
                 services.AddSingleton<IStartupFilter, ApplicationInsightsStartupFilter>();
 
                 services.AddSingleton<JavaScriptSnippet>();
-                services.AddSingleton<ApplicationInsightsLoggerCallbacks>();
+                services.AddSingleton<ApplicationInsightsLoggerEvents>();
 
                 services.AddOptions();
                 services.AddSingleton<IOptions<TelemetryConfiguration>, TelemetryConfigurationOptions>();
@@ -277,7 +277,7 @@ internal static void AddTelemetryConfiguration(IConfiguration config, Applicatio
 
         private static bool IsApplicationInsightsAdded(IServiceCollection services)
         {
-            // We treat ApplicationInsightsInitializer as a marker that AI services were addede to service collection
+            // We treat ApplicationInsightsInitializer as a marker that AI services were added to service collection
             return services.Any(service => service.ServiceType == typeof(ApplicationInsightsInitializer));
         }
     }

src/Microsoft.ApplicationInsights.AspNetCore/Logging/Implementation/ApplicationInsightsLoggerEvents.cs

@@ -0,0 +1,23 @@
+namespace Microsoft.ApplicationInsights.AspNetCore.Logging
+{
+    using System;
+
+    /// <summary>
+    /// Class to provide ApplicationInsights logger events
+    /// </summary>
+    internal class ApplicationInsightsLoggerEvents
+    {
+        /// <summary>
+        /// Event that is fired when new ApplicationInsights logger is added.
+        /// </summary>
+        public event Action LoggerAdded;
+
+        /// <summary>
+        /// Invokes LoggerAdded event.
+        /// </summary>
+        public void OnLoggerAdded()
+        {
+            LoggerAdded?.Invoke();
+        }
+    }
+}

src/Microsoft.ApplicationInsights.AspNetCore/Logging/Implementation/ApplicationInsightsLoggerFactoryExtensions.cs

@@ -50,7 +50,7 @@ public static ILoggerFactory AddApplicationInsights(
             IServiceProvider serviceProvider,
             Func<string, LogLevel, bool> filter)
         {
-            return factory.AddApplicationInsights(serviceProvider, filter, () => { });
+            return factory.AddApplicationInsights(serviceProvider, filter, null);
         }
 
         /// <summary>
@@ -59,18 +59,24 @@ public static ILoggerFactory AddApplicationInsights(
         /// <param name="factory"></param>
         /// <param name="filter"></param>
         /// <param name="serviceProvider">The instance of <see cref="IServiceProvider"/> to use for service resolution.</param>
-        /// <param name="loggerAddedCallback">The callback that get's executed when another ApplicationInsights logger is added.</param>
+        /// <param name="loggerAddedCallback">The callback that gets executed when another ApplicationInsights logger is added.</param>
         public static ILoggerFactory AddApplicationInsights(
             this ILoggerFactory factory,
             IServiceProvider serviceProvider,
             Func<string, LogLevel, bool> filter,
             Action loggerAddedCallback)
         {
             var client = serviceProvider.GetService<TelemetryClient>();
-            if (loggerAddedCallback != null)
+            var debugLoggerControl = serviceProvider.GetService<ApplicationInsightsLoggerEvents>();
+
+            if (debugLoggerControl != null)
             {
-                var debugLoggerControl = serviceProvider.GetService<ApplicationInsightsLoggerCallbacks>();
-                debugLoggerControl?.AddLoggerCallback(loggerAddedCallback);
+                debugLoggerControl.OnLoggerAdded();
+
+                if (loggerAddedCallback != null)
+                {
+                    debugLoggerControl.LoggerAdded += loggerAddedCallback;
+                }
             }
 
             factory.AddProvider(new ApplicationInsightsLoggerProvider(client, filter));