Skip to content

add MaxInstantRetry XML Element in Channel configuration #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhaval24 merged 1 commit into from
Mar 14, 2018
Merged

add MaxInstantRetry XML Element in Channel configuration #604

dhaval24 merged 1 commit into from
Mar 14, 2018

Conversation

@dhaval24
Copy link
Contributor

@dhaval24 dhaval24 commented Mar 11, 2018

Fix #591

This PR adds ability to configure MAX_INSTANT_RETRIES from the channel configuration.

@dhaval24 dhaval24 requested review from grlima and littleaj March 11, 2018 20:21
@dhaval24
Copy link
Contributor Author

dhaval24 commented Mar 11, 2018

@debugthings don't worry about this! I was playing around the code and added this small enhancement :-)

@dhaval24 dhaval24 self-assigned this Mar 11, 2018
@dhaval24 dhaval24 added this to the 2.0.2 milestone Mar 11, 2018
littleaj
littleaj approved these changes Mar 13, 2018
View reviewed changes
Copy link
Contributor

@littleaj littleaj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhaval24, This looks good, but did you intend the config value to be used somewhere? or is that in another PR?

@dhaval24
Copy link
Contributor Author

dhaval24 commented Mar 13, 2018

@littleaj thanks for reviewing. So James' PR #561 uses this configuration value. It's just that the value was never getting passed from XML. I just added it in this PR :-)

@littleaj
Copy link
Contributor

littleaj commented Mar 13, 2018

@dhaval24 ok cool. Thanks!

@dhaval24 dhaval24 merged commit a15ee07 into master Mar 14, 2018
@grlima grlima deleted the AddXmlAttributeForMaxInstantRetries branch March 15, 2018 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grlima grlima Awaiting requested review from grlima

1 more reviewer

@littleaj littleaj littleaj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dhaval24 dhaval24

Labels

Enhancement

Projects

None yet

Milestone

2.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@dhaval24 @littleaj