Enable Cold Start #602
Enable Cold Start #602
Conversation
| boolean debugMode = Boolean.valueOf(debugModeAsString); | ||
| agentConfiguration.setDebugMode(debugMode); | ||
| InternalAgentLogger.INSTANCE.logAlways(InternalAgentLogger.LoggingLevel.ERROR, "Instrumentation debug mode set to '%s'", debugMode); | ||
| InternalAgentLogger.INSTANCE.warn("Instrumentation debug mode set to '%s'", debugMode); |
There was a problem hiding this comment.
IMO, this is an info message.
There was a problem hiding this comment.
Sure should be info. I dropped one level down (it was ERROR before). I will drop it down to INFO. Thanks for pointing out.
| } catch (FileNotFoundException e) { | ||
| InternalLogger.INSTANCE.logAlways(InternalLogger.LoggingLevel.WARN, "Configuration file '%s' could not be opened for reading", configurationFile); | ||
| InternalLogger.INSTANCE.trace("stack trace is %s", ExceptionUtils.getStackTrace(e)); | ||
| InternalLogger.INSTANCE.warn("Configuration file '%s' could not be opened for reading %s", configurationFile, |
There was a problem hiding this comment.
generally, i think it's a good idea to have a colon (:) before the stack trace printout.
There was a problem hiding this comment.
Sure will add a colon before stacktrace statements.
| } | ||
| } else { | ||
| InternalLogger.INSTANCE.logAlways(InternalLogger.LoggingLevel.WARN, "Configuration file '%s' could not be found", configurationFileName); | ||
| InternalLogger.INSTANCE.error("Configuration file '%s' could not be found", configurationFileName); |
There was a problem hiding this comment.
Why error instead of warn?
There was a problem hiding this comment.
I thought that AI configuration file is required. I am aware that there is certain sort of default configuration but still I thought that config file has iKey. unless user passes it as an environment variable it needs to be present here.
|
@littleaj just added a commit to better decorate the log messages. |
|
@littleaj I have merged the latest master and have resolved all the merge conflicts. Please take a look once and then I would merge this. |
littleaj
left a comment
littleaj
left a comment
There was a problem hiding this comment.
@dhaval24 Looks good; with one comment:
Run the gradle prepare task and make sure the <p> tags with no closing tag in the javadoc don't cause the javadoc task to fail. I'd rather catch that now than when we are trying to release.
|
@littleaj thanks I ran |
This PR Enables the cold start of the SDK by removing most of the logAlways() calls. Only throttling statements now have logAlways() calls in the SDK. Every other place this call has been removed to reduce tracing.
Fix #590