Fixed javadocs tags, that caused build errors

[Mart-Bogdan]

Fixed javadocs tags, that caused build errors while executing javadoc gradle task

P.S. do I need issue and CHANGELOG for this tiny fix?

[msftclas]

All CLA requirements met.

[dhaval24]

@Mart-Bogdan I don't think you need change logs. But I do have a fundamental question here. Why do we need to have this import statements if these classes are not used anywhere in the file. Just having imports for docs doesn't make sense and would add overhead. I did bit of search around this and seemed like older version of Java Docs had a bug regarding this but is no longer in later version.

[littleaj]

@dhaval24 This is just what is needed. It either needs import statements or FQ name so the javadoc generator can find the symbols.

Also, import statements only affect compile time. There unused imports have no effect on bytecode.

[Mart-Bogdan]

Hello, @dhaval24 , I uderstand why you are against imports, while it's not affecting generated code.

Issue I may think of is that IDE shows full class name in Doc explorer

In contrast of:

But I've decided to double-check, generated HTML documentation shows short names, so it seems ok:

It's no problem for me to change imports.

Just thought, perhaps some IDE unaware of doc coments removed "unused imports"?

So what reolution would be, I could specify types exactly,
but doing fillowing is unlikely {@link com.microsoft.applicationinsights.internal.channel.common.PartialSuccessHandler PartialSuccessHandler}

[dhaval24]

@littleaj I disagree on this. I do not think that it is appropriate to keep the unused import statements in the code base. I think this is absolutely a bad practice and be it any phase (compile or runtime optimization should be emphasized). If we need to replace this by FQ names we should replace it with fully qualify names. Also I thought that this bug is more or less fixed.

https://bugs.java.com/view_bug.do?bug_id=4652655

[dhaval24]

@Mart-Bogdan thank you for understanding the concerns here. I would personally much appreciate if you can change this to fully qualified names instead. I believe this was a bug way back and all modern industry IDEs including Intellij and Eclipse should have this in their latest releases fixed :)

[Mart-Bogdan]

@dhaval24 I've changed imports, as you suggested.

By the way, I'm pushing to 2.0.0-STABLE branch, don't know is that OK.

we talked about it

[littleaj]

Thanks for catching this @Mart-Bogdan !