Skip to content

Conversation

@panovic
Copy link

@panovic panovic commented Dec 19, 2017

Fix # .

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed
  • CHANGELOG.md updated

@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ panovic sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@dhaval24 dhaval24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panovic Thank you very much for your vital contribution towards the Application Insights Java SDK. It is really valuable. Everything seems to be fine. Just would like to know if we can add a test case for this?

@dhaval24 dhaval24 added this to the 2.0.1 milestone Dec 19, 2017
@dhaval24 dhaval24 added the Bug label Dec 19, 2017
@dhaval24
Copy link
Contributor

@panovic also please sign CLA :-)

@dhaval24
Copy link
Contributor

@panovic closing this PR as discussed because #561 fixes adds the whole reliable channel logic.

@dhaval24 dhaval24 closed this Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants