Fix request exception not captured when INSTRUMENTATION_LOGGING_LEVEL=OFF #4130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
TimothyMothra,
harsimar,
heyams,
jeanbisutti,
rajkumar-rangaraj and
ramthi
as code owners
trask
force-pushed
the
better-support-for-log-level-off
branch
from
afb77f5 to
31abb63
Compare
trask
force-pushed
the
better-support-for-log-level-off
branch
from
31abb63 to
90f4ece
Compare
trask
force-pushed
the
better-support-for-log-level-off
branch
6 times, most recently
from
1791dff to
bd68b98
Compare
trask
force-pushed
the
better-support-for-log-level-off
branch
2 times, most recently
from
a6b7463 to
76e64e6
Compare
trask
commented
Mar 13, 2025
...c/main/java/com/microsoft/applicationinsights/agent/internal/exporter/AgentSpanExporter.java
Outdated
Show resolved
Hide resolved
trask
force-pushed
the
better-support-for-log-level-off
branch
from
76e64e6 to
13e58d9
Compare
jeanbisutti
reviewed
Mar 14, 2025
...ng/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java
Show resolved
Hide resolved
jeanbisutti
reviewed
Mar 14, 2025
...ng/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java
Outdated
Show resolved
Hide resolved
jeanbisutti
previously approved these changes
Mar 25, 2025
...ain/java/com/microsoft/applicationinsights/agent/internal/init/AzureMonitorLogProcessor.java
Show resolved
Hide resolved
| return props; | ||
| }) | ||
| .addPropertiesCustomizer(new AiConfigCustomizer()) | ||
| .addLogRecordProcessorCustomizer( |
Member
There was a problem hiding this comment.
Suggestion: an extract method could be applied to this customizer, and addLogRecordProcessorCustomizer could be used next to .addLogRecordExporterCustomizer. In this way it would be easier to notice the whole picture for logging.
…ights/agent/internal/init/AzureMonitorLogProcessor.java Co-authored-by: Jean Bisutti <jean.bisutti@gmail.com>
jeanbisutti
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4095