Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-string type telemetry processor attributes #3388

Merged
merged 20 commits into from
Dec 5, 2023
Merged

Support non-string type telemetry processor attributes #3388

merged 20 commits into from
Dec 5, 2023

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Nov 15, 2023

Fix #3378

@heyams heyams marked this pull request as draft November 15, 2023 22:45
@heyams
Copy link
Contributor Author

heyams commented Nov 15, 2023

need to fix test

@heyams heyams marked this pull request as ready for review November 16, 2023 02:49
@heyams
Copy link
Contributor Author

heyams commented Nov 30, 2023

#3378 (comment)
customer confirmed both strict and regex work.

@heyams heyams merged commit 7498f01 into main Dec 5, 2023
@heyams heyams deleted the heya/dev branch December 5, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbisutti jeanbisutti jeanbisutti left review comments

@trask trask trask approved these changes

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telemetry processors bug
3 participants
@heyams @trask @jeanbisutti