Bring up profiler in response to user enabling it #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnoliver
force-pushed
the
enable-on-demand-2
branch
from
1a3235b to
0fe8a72
Compare
johnoliver
force-pushed
the
enable-on-demand-2
branch
from
0fe8a72 to
bbc5c9e
Compare
johnoliver
requested review from
heyams,
jeanbisutti,
ramthi and
trask
as code owners
karianna
suggested changes
Jan 26, 2023
...c-monitor-core/src/main/java/com/microsoft/gcmonitor/notifications/NotificationObserver.java
Show resolved
Hide resolved
...c-monitor-core/src/main/java/com/microsoft/gcmonitor/notifications/NotificationObserver.java
Show resolved
Hide resolved
...i/src/main/java/com/microsoft/applicationinsights/alerting/config/AlertingConfiguration.java
Show resolved
Hide resolved
.../main/java/com/microsoft/applicationinsights/agent/internal/configuration/Configuration.java
Outdated
Show resolved
Hide resolved
.../com/microsoft/applicationinsights/agent/internal/profiler/PerformanceMonitoringService.java
Show resolved
Hide resolved
.../com/microsoft/applicationinsights/agent/internal/profiler/PerformanceMonitoringService.java
Show resolved
Hide resolved
...ain/java/com/microsoft/applicationinsights/agent/internal/profiler/ProfilingInitializer.java
Show resolved
Hide resolved
...ain/java/com/microsoft/applicationinsights/agent/internal/profiler/ProfilingInitializer.java
Outdated
Show resolved
Hide resolved
...ain/java/com/microsoft/applicationinsights/agent/internal/profiler/ProfilingInitializer.java
Show resolved
Hide resolved
johnoliver
force-pushed
the
enable-on-demand-2
branch
from
3f6b78e to
c758a0f
Compare
trask
reviewed
Jan 30, 2023
.../main/java/com/microsoft/applicationinsights/agent/internal/configuration/Configuration.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java
Outdated
Show resolved
Hide resolved
.../com/microsoft/applicationinsights/agent/internal/profiler/PerformanceMonitoringService.java
Show resolved
Hide resolved
.../com/microsoft/applicationinsights/agent/internal/profiler/PerformanceMonitoringService.java
Show resolved
Hide resolved
.../com/microsoft/applicationinsights/agent/internal/profiler/config/ProfilerConfiguration.java
Show resolved
Hide resolved
|
trask
approved these changes
Jan 31, 2023
| @@ -397,7 +407,7 @@ protected Set<Integer> getLivenessCheckPorts() { | |||
| "-Dapplicationinsights.testing.global-ingestion-endpoint=" + FAKE_INGESTION_ENDPOINT); | |||
| } | |||
| if (REMOTE_DEBUG) { | |||
| javaToolOptions.add("-agentlib:jdwp=transport=dt_socket,address=5005,server=y,suspend=y"); | |||
| javaToolOptions.add("-agentlib:jdwp=transport=dt_socket,address=*:5005,server=y,suspend=y"); | |||
| static class JavaProfilerConfiguredTest extends JavaProfileConfigTest { | ||
| @RegisterExtension | ||
| static final SmokeTestExtension testing = | ||
| BASE_BUILDER.setProfilerEndpoint(ProfilerState.configuredEnabled).build(); |
There was a problem hiding this comment.
I'd suggest something like below, and construct the baseBuilder each time (since it's not immutable):
Suggested change
| BASE_BUILDER.setProfilerEndpoint(ProfilerState.configuredEnabled).build(); | |
| baseBuilder().setProfilerEndpoint(ProfilerState.configuredEnabled).build(); |
| import javax.servlet.http.HttpServletRequest; | ||
| import javax.servlet.http.HttpServletResponse; | ||
|
|
||
| public class MockedProfilerSettingsServlet extends HttpServlet { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix # .
For significant contributions please make sure you have completed the following items: