Update to otel 1.18.0 #2509
Merged
Update to otel 1.18.0 #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
reviewed
Sep 9, 2022
...er/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/SpanDataMapper.java
Outdated
Show resolved
Hide resolved
|
might want to fix this todo: |
trask
force-pushed
the
update-to-otel-1.18.0
branch
from
2e4f737 to
ca1340d
Compare
trask
force-pushed
the
update-to-otel-1.18.0
branch
2 times, most recently
from
316af6b to
02e5312
Compare
trask
changed the base branch from
main
to
fix-sampling-for-custom-instrumentation
Base automatically changed from
fix-sampling-for-custom-instrumentation
to
main
September 15, 2022 20:31
trask
force-pushed
the
update-to-otel-1.18.0
branch
from
6b4389b to
8038293
Compare
heyams
reviewed
Sep 16, 2022
| @@ -93,6 +94,8 @@ public void init() { | |||
|
|
|||
| StartupDiagnostics.execute(); | |||
|
|
|||
| InternalLogger.initialize(Slf4jInternalLogger::create); | |||
There was a problem hiding this comment.
Upstream logging changed significantly in this last release: open-telemetry/opentelemetry-java-instrumentation#6543
heyams
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #2513