-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to OpenTelemetry 1.17.0 #2453
Conversation
.../main/java/com/microsoft/applicationinsights/agent/internal/configuration/Configuration.java
Show resolved
Hide resolved
...ng/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java
Show resolved
Hide resolved
...ng/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java
Show resolved
Hide resolved
Search and fix 2 issues:
|
...ng/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java
Outdated
Show resolved
Hide resolved
...ng/src/main/java/com/microsoft/applicationinsights/agent/internal/init/SecondEntryPoint.java
Show resolved
Hide resolved
will you fix these in this PR? |
done |
2022-08-31 14:18:12.815+01:00 WARN c.m.a.a.i.c.ConfigurationBuilder - Unrecognized field "masking" (class com.microsoft.applicationinsights.agent.internal.configuration.Configuration$EnabledByDefaultInstrumentation), not marked as ignorable (one known property: "enabled"]) Got following error with 3.3.1 agent version and "jdbc": { |
hi @asos-jitu! you will need to use 3.4.0-BETA for this new feature: https://github.com/microsoft/ApplicationInsights-Java/releases/tag/3.4.0-BETA |
The masking enables option should be available for all db.types and not only jdbc. Not working for a mongo type and is failing while starting with the following error 2022-09-02 12:27:20.134+01:00 WARN c.m.a.a.i.c.ConfigurationBuilder - Unrecognized field "masking" (class com.microsoft.applicationinsights.agent.internal.configuration.Configuration$EnabledByDefaultInstrumentation), not marked as ignorable (one known property: "enabled"]) |
hi @asos-jitu! can you open a new issue so we can track this? the current configuration option only applies to jdbc, but we should be able to add a similar configuration option to mongo |
Hi @trask any dates for releasing the 3.4.0-BETA version? |
hi @asos-jitu 3.4.0-BETA is released: https://github.com/microsoft/ApplicationInsights-Java/releases |
Includes a fix for role name and ikey overrides.
Also adds new config for upstream option:
Resolves #1989 (disabling the jdbc masking)