Skip to content

Conversation

trask
Copy link
Member

@trask trask commented Aug 14, 2022

Introduces

  • AzureMonitorSpanProcessor - handles operation name propagation
  • AzureMonitorSampler - implements Azure Monitor trace-id hashing based sampler

Removes

  • Agent's AiSampler which used tracestate to propagate sampling decision (and so required coordination with propagator to suppress propagating that tracestate since it wasn't a standard so didn't want to expose that publicly)

Fixes

  • Agent's default sampling behavior to not be "parent-based" because that doesn't support accurate "item counts" since item count isn't propagated in tracestate (hopefully some day)
  • Replaces configuration option ignoreRemoteParentNotSampled with better descriptive parentBased (under sampling preview)

Side effect:

This behavior change around parent-based sampling probably deserves a minor version bump (to 3.4.0) and we should post follow-ups to #2152 and #1883 where the ignoreRemoteParentNotSampled was previously discussed.

@trask trask force-pushed the sampling branch 2 times, most recently from 02e574d to cb1120e Compare August 15, 2022 03:33
@trask trask changed the title Sampling Support item count and operation name in azmonexporter Aug 15, 2022
@trask trask force-pushed the sampling branch 3 times, most recently from 743f3e6 to 7fcab41 Compare August 15, 2022 15:05
@trask trask marked this pull request as ready for review August 15, 2022 15:56
@trask trask merged commit 2259d46 into main Aug 19, 2022
@trask trask deleted the sampling branch August 19, 2022 20:07
@trask trask mentioned this pull request Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants