-
Notifications
You must be signed in to change notification settings - Fork 207
Support item count and operation name in azmonexporter #2443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02e574d
to
cb1120e
Compare
743f3e6
to
7fcab41
Compare
heyams
reviewed
Aug 19, 2022
...oling/src/main/java/com/microsoft/applicationinsights/agent/internal/init/AppIdSupplier.java
Show resolved
Hide resolved
...xporter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorLogProcessor.java
Outdated
Show resolved
Hide resolved
...porter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorSpanProcessor.java
Outdated
Show resolved
Hide resolved
...ter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/LogDataMapper.java
Outdated
Show resolved
Hide resolved
...ter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/LogDataMapper.java
Outdated
Show resolved
Hide resolved
...er/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/OperationNames.java
Outdated
Show resolved
Hide resolved
...in/java/com/azure/monitor/opentelemetry/exporter/implementation/logging/OperationLogger.java
Show resolved
Hide resolved
heyams
reviewed
Aug 19, 2022
.../main/java/com/microsoft/applicationinsights/agent/internal/configuration/Configuration.java
Show resolved
Hide resolved
heyams
reviewed
Aug 19, 2022
...ooling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/Samplers.java
Show resolved
Hide resolved
...ooling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/Samplers.java
Show resolved
Hide resolved
...ooling/src/main/java/com/microsoft/applicationinsights/agent/internal/sampling/Samplers.java
Show resolved
Hide resolved
heyams
approved these changes
Aug 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
AzureMonitorSpanProcessor
- handles operation name propagationAzureMonitorSampler
- implements Azure Monitor trace-id hashing based samplerRemoves
AiSampler
which used tracestate to propagate sampling decision (and so required coordination with propagator to suppress propagating that tracestate since it wasn't a standard so didn't want to expose that publicly)Fixes
ignoreRemoteParentNotSampled
with better descriptiveparentBased
(under sampling preview)Side effect:
This behavior change around parent-based sampling probably deserves a minor version bump (to 3.4.0) and we should post follow-ups to #2152 and #1883 where the
ignoreRemoteParentNotSampled
was previously discussed.