-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off oshi logging #2086
Turn off oshi logging #2086
Conversation
@@ -62,7 +63,9 @@ public void initLoggerLevels(LoggerContext loggerContext) { | |||
public void updateLoggerLevel(Logger logger) { | |||
Level loggerLevel; | |||
String name = logger.getName(); | |||
if (name.startsWith("reactor.netty") || name.startsWith("io.netty")) { | |||
if (name.startsWith("oshi")) { | |||
loggerLevel = Level.OFF; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
completely off @trask?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
selfDiagnostic level -> oshi level
- INFO or higher -> OFF
- DEBUG -> INFO
- TRACE -> TRACE
similar to getDefaultLibraryLevel but slightly different
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
* Support Statsbeat in EU regions (#2082) * Use a diff statsbeat ikey in eu regions * Use lowercase * Fix spotless * Reserve statsbeat config when applicable * Make test easier to understand * Remove unused constants * Decouple TelemetryClient * Add comments * Refactor * Fix spotless * Remove assignment * Fix tests * Convert url to string * Use regex * Strict protocol * No need to escape dash * Remove escape * Add a startup profiler for debugging (#2085) * Add StartupProfiler * Fix errorprone * Fix spotless * Invoke before premain Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Create dump in applicationinsights folder * Show the full path of the dump * Fix lgtm * Allow sout * Fix lgtm * Supress systemout at the method level * Fix style complain * Address comments * Fix spotless * Address comments * Return when exception occurs * Remove comment Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Use getBoolean for system property Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * Fix startup profiling (#2092) * Fix startup profiling * errorprone * Shorten host property in network statsbeat (#2087) * Shorten host * Use regex * Fix spotless * Strict protocol * Remove sout debugging * Remove escape . * Send endpointUrl when region is not found * Turn off oshi logging (#2086) * Turn off oshi logging * Update oshi logger level * Don't mark throttle as error (#2079) * Update azure-core dependency (#2095) Co-authored-by: Helen Y <56097766+heyams@users.noreply.github.com>
No description provided.