Track disk IO via Non-essential statsbeat #1925

heyams · 2021-10-22T20:45:12Z

No description provided.

...main/java/com/microsoft/applicationinsights/agent/internal/localstorage/LocalFileSender.java

...main/java/com/microsoft/applicationinsights/agent/internal/localstorage/LocalFileWriter.java

...n/java/com/microsoft/applicationinsights/agent/internal/statsbeat/NonessentialStatsbeat.java

...rc/main/java/com/microsoft/applicationinsights/agent/internal/statsbeat/StatsbeatModule.java

...va/com/microsoft/applicationinsights/agent/internal/statsbeat/NonessentialStatsbeatTest.java

...main/java/com/microsoft/applicationinsights/agent/internal/localstorage/LocalFileSender.java

trask

instead of the latest change which seems to have complicated things a bit, how about injecting NonessentialStatsbeat into the LocalFileLoader, and then you can have more fine-grained control of logging failures directly inside of loadTelemetriesFromDisk()

heyams · 2021-10-26T23:49:43Z

instead of the latest change which seems to have complicated things a bit, how about injecting NonessentialStatsbeat into the LocalFileLoader, and then you can have more fine-grained control of logging failures directly inside of loadTelemetriesFromDisk()

that was my first attempt and later realized it's less code change doing this way. it just eliminates one case where failure count doesn't apply. Loader is the only place where loadTelemetriesFromDisk is called disregarding tests.

…r level

…standing

...main/java/com/microsoft/applicationinsights/agent/internal/localstorage/LocalFileLoader.java

...main/java/com/microsoft/applicationinsights/agent/internal/localstorage/LocalFileWriter.java

...main/java/com/microsoft/applicationinsights/agent/internal/localstorage/LocalFileLoader.java

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

…tionInsights-Java into heya/statsbeat

heyams · 2021-10-27T20:44:37Z

@ramthi can you take a look at it again? you're currently blocking the merge. i have addressed all your comments. thanks.

heyams added 9 commits October 22, 2021 12:10

Just track read and write failures

280d4bd

Increment read/write failure counters

6362175

Simplify a bit

7ca9bb8

Fix tests

0dbb973

Fix spotlessApply

9490268

Remove a comment

7c1c5bf

Update smoke test

c5802fa

Fix smoke test

93e0743

Add unit tests

ba25a6b

heyams marked this pull request as ready for review October 22, 2021 22:01

heyams requested review from kryalama, trask and xiao-lix as code owners October 22, 2021 22:01

Fix smoke test

c2b17d2

ramthi requested changes Oct 25, 2021

View reviewed changes

Add comments

87b0df2

trask reviewed Oct 26, 2021

View reviewed changes

...main/java/com/microsoft/applicationinsights/agent/internal/localstorage/LocalFileSender.java Outdated Show resolved Hide resolved

heyams added 2 commits October 26, 2021 15:54

Don't increment read failure count where there is no file to be loaded

17fcf94

Fix smoke test

c0e5bfd

trask reviewed Oct 26, 2021

View reviewed changes

heyams added 5 commits October 26, 2021 18:04

Increment read failure count at the exception level, not at the highe…

f46f5d7

…r level

Increment write failure count at the exception level for easier under…

e5c04e9

…standing

Fix unit tests

c501e03

Be consistent and getter used by tests only

05b4ba8

Add a todo

af7a1fb

trask reviewed Oct 27, 2021

View reviewed changes

heyams and others added 3 commits October 27, 2021 11:46

Add comment

cb3e1f9

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Delete

9452da1

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Add a comment

8efa37a

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

heyams added 3 commits October 27, 2021 11:48

Remove this

a401caf

Merge branch 'heya/statsbeat' of https://github.com/microsoft/Applica…

9296281

…tionInsights-Java into heya/statsbeat

Fix spotlessApply

6bf134f

trask approved these changes Oct 27, 2021

View reviewed changes

heyams requested a review from ramthi October 27, 2021 20:46

ramthi approved these changes Oct 27, 2021

View reviewed changes

heyams merged commit 1ded29a into main Oct 27, 2021

heyams deleted the heya/statsbeat branch October 27, 2021 22:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Track disk IO via Non-essential statsbeat #1925

Track disk IO via Non-essential statsbeat #1925

heyams commented Oct 22, 2021

trask left a comment

heyams commented Oct 26, 2021

heyams commented Oct 27, 2021

Track disk IO via Non-essential statsbeat #1925

Track disk IO via Non-essential statsbeat #1925

Conversation

heyams commented Oct 22, 2021

trask left a comment

Choose a reason for hiding this comment

heyams commented Oct 26, 2021

heyams commented Oct 27, 2021