Fix ChannelFetcher memory leak #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littleaj
reviewed
Jan 8, 2020
Contributor
littleaj
left a comment
littleaj
left a comment
There was a problem hiding this comment.
Some comments below.
Also, I noticed we synchronize register but not the "stop all" loop. I think we should synchronize in both places.
If I could rewrite this operation (just thinking out loud):
- I would add
shutdown(),shutdownNow()andawaitTermination(long, TimeUnit)to TelemetryClient. - The resources of each instance would be tracked within that instance.
- The user of a TelmetryClient instance should be sure to call shutdown to cleanup its resources.
- The shutdown hook action would have a WeakHashMap (as you did here) of TelemetryClient references to close any still alive during JVM exit. A new instance would register itself here.
core/src/main/java/com/microsoft/applicationinsights/internal/shutdown/SDKShutdownActivity.java
Show resolved
Hide resolved
core/src/main/java/com/microsoft/applicationinsights/internal/shutdown/SDKShutdownActivity.java
Show resolved
Hide resolved
core/src/main/java/com/microsoft/applicationinsights/TelemetryClient.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/microsoft/applicationinsights/internal/shutdown/SDKShutdownActivity.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/microsoft/applicationinsights/internal/shutdown/SDKShutdownActivity.java
Outdated
Show resolved
Hide resolved
littleaj
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.