Skip to content

Fix springboot dependencies #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
littleaj merged 2 commits into from
Dec 10, 2019
Merged

Fix springboot dependencies #1171

littleaj merged 2 commits into from
Dec 10, 2019

Conversation

@littleaj
Copy link
Contributor

@littleaj littleaj commented Dec 4, 2019

This does a few things:

  1. Fixes the unnecessary inclusion of xmlpull and xstream in spring boot shadow
  2. Uses shadow configuration for core and web so we don't have to manage their dependencies here (related to 1)
  3. Removes an unnecessary relocation.

@littleaj littleaj requested a review from trask December 4, 2019 22:48
@littleaj littleaj self-assigned this Dec 4, 2019
trask
trask reviewed Dec 4, 2019
View reviewed changes
Copy link
Member

@trask trask left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, one comment below (above? i can't remember 😂)

@littleaj littleaj modified the milestones: 2.6.0-BETA, 2.6.0-BETA.2 Dec 5, 2019
@littleaj littleaj marked this pull request as ready for review December 7, 2019 01:00
@littleaj littleaj merged commit 4cecc44 into master Dec 10, 2019
@littleaj littleaj deleted the littleaj/fix_springboot_dependencies branch December 10, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trask trask trask approved these changes

Assignees

@littleaj littleaj

Labels

None yet

Projects

None yet

Milestone

2.6.0-BETA.2

Development

Successfully merging this pull request may close these issues.

3 participants

@littleaj @trask