Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where no new scene is rendered after simContinueForTime #3305

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

niekvleeuwen
Copy link
Contributor

@niekvleeuwen niekvleeuwen commented Jan 14, 2021

Fixes: #3304
When comparing the images before and after calling simContinueForTime, I noticed that the images are the same. This pull request fixes this issue. Please see #3304 for a more detailed explanation.

@jonyMarino
Copy link
Collaborator

It needs investigation why the MacOS check is failing.

@zimmy87 zimmy87 closed this Jun 28, 2021
@zimmy87 zimmy87 reopened this Jun 28, 2021
@zimmy87
Copy link
Contributor

zimmy87 commented Jun 30, 2021

Tested with pause_continue_drone.py and a custom script for repro'ing #3304; didn't notice a regression with either. MacOS build check failure went away after merging with master so this looks good to me now, moving ahead with merge.

@zimmy87 zimmy87 merged commit c6d3f96 into microsoft:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scene doesn't change after calling simContinueForTime with a low value
3 participants