Fix C4244 warnings in build.cmd and issue with manually placing pawns #3146
Conversation
By adding a static_cast to various calculations inside calculateMaxThrust, two C4244 warnings that appear when running build.cmd can be avoided Co-Authored-By: Jonathan <jonymarino@gmail.com>
This adds logic for finding the primary pawn and setting the camera position to the location of this pawn Co-Authored-By: Jonathan <jonymarino@gmail.com>
|
|
zimmy87
changed the title
| @@ -68,6 +68,8 @@ class VehicleSimApiBase : public msr::airlib::UpdatableObject { | |||
| //use pointer here because of derived classes for VehicleSetting | |||
| const AirSimSettings::VehicleSetting* getVehicleSetting() const | |||
| { | |||
| if (getVehicleName().find("BP_FlyingPawn") == 0) | |||
There was a problem hiding this comment.
We should change this for any vehicle name
|
@zimmy87, please resolve the current conflict with master. Good luck! |
accidentally reinitialized a variable in the previous merge with https://github.com/microsoft/AirSim
accidentally reinitialized a variable in the previous merge with https://github.com/microsoft/AirSim
* master: update mavlink 2.0 message definitions. fix broken unreal build due to disconnected asset add 2 new tested devices. fix auto-detect of pixhawk 4 hardware fixing build break with previous merge fixing build break with previous merge changes to clock_speed.py responding to comments on PR microsoft#3146 set camera to position of pawn (microsoft#3050) Add static_cast to calculateMaxThrust (microsoft#3136) Fixed OriginGeopoint GPS error remove mislead comment on vs version Update px4_logging.md fix typo assigning fpv_pawn when there are pawns in environment fixing crash for ue added pawns and preventing default pawn to be created Update simple_flight.md
|
This issue with warnings could have been avoided if the CI was active I think |
|
Hi @rajat2004! Yes, you are totally right. We want to improve our CI tools. Why would you prefer GitHub Actions instead of Travis and Azure Pipelines? |
|
It's not that I prefer one over the other, Travis & Azure are already present so it would be pretty easy to have them up and running again. Azure specifically would be great since it does the entire build with UE included |
|
I've opened #3180 which adds Ubuntu & Windows builds, and it did pick up the compilation error on Windows. The checks aren't being run on the PR, most likely needs some enabling by the maintainers, or maybe will work after getting merged. See the PR on my fork (rajat2004#26) or the branch itself which will show the checks being executed |
This PR contains two bug fixes. The first is for C4244 warnings that get treated as errors, thus breaking the build.cmd script. The other is an issue where removing a PlayerStart and manually placing a build can cause a crash and also incorrectly places the camera (previously it was defaulting the camera to the position of the camera in the Editor, instead of placing the camera next to the pawn)