Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Improvements #2760

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Build Improvements #2760

merged 2 commits into from
Jul 21, 2020

Conversation

rajat2004
Copy link
Contributor

@rajat2004 rajat2004 commented Jun 9, 2020 •
edited
Loading

  1. setup.sh: Exit script immediately if command exits, unzip quietly (reduces output quite a bit on Travis)
  2. Unity: exit script immediately if build fails (Now Linux builds will also fail)

Fixes #2759

@rajat2004 rajat2004 mentioned this pull request Jun 9, 2020
Closed
@rajat2004 rajat2004 changed the title [setup] Exit script immediately if command exits with non-zero status Build Improvements Jul 7, 2020
@madratman
Copy link
Contributor

this would need a rebase, I did something partially similar with the recent update

@rajat2004
Copy link
Contributor Author

Rebased on master

@madratman madratman merged commit 65a825b into microsoft:master Jul 21, 2020
@rajat2004 rajat2004 deleted the script-exit branch July 21, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup.sh reports successful even with errors
2 participants
@rajat2004 @madratman