FIC Connection support

[rodrigobr-msft]

This pull request introduces support for a new "FederatedCredentials" authentication type. The main changes include adding the new authentication type, updating configuration options, and implementing the logic to acquire tokens for federated credentials.

Authentication Enhancements:

• Added a new authentication type federated_credentials to the AuthTypes enumeration, enabling support for federated credentials authentication flows.
• Extended AgentAuthConfiguration to include a new FEDERATED_CLIENT_ID property, and updated the constructor to accept this parameter. [1] [2]
• Implemented logic in msal_auth.py to handle the new federated_credentials type, acquiring an access token using a managed identity client and caching it for subsequent use.

[Copilot]

Pull request overview

Adds a new authentication mode intended to support “FederatedCredentials” across the hosting-core configuration surface and the MSAL-based token acquisition implementation.

Changes:

• Added AuthTypes.federated_credentials to the auth type enum.
• Extended AgentAuthConfiguration with a FEDERATED_CLIENT_ID field.
• Added a new federated_credentials branch in MsalAuth._create_client_application and did minor formatting cleanup in AgentApplication error raising.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/authorization/auth_types.py	Adds the new federated_credentials enum value.
libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/authorization/agent_auth_configuration.py	Adds configuration storage for FEDERATED_CLIENT_ID.
libraries/microsoft-agents-hosting-core/microsoft_agents/hosting/core/app/agent_application.py	Refactors ApplicationError raising formatting (no functional change).
libraries/microsoft-agents-authentication-msal/microsoft_agents/authentication/msal/msal_auth.py	Introduces token acquisition logic for the new auth type.

Comments suppressed due to low confidence (1)

libraries/microsoft-agents-authentication-msal/microsoft_agents/authentication/msal/msal_auth.py:264

• federated_credentials branch is using a ManagedIdentityClient to fetch an access token and then storing that access token into client_credential for ConfidentialClientApplication. MSAL interprets a string client_credential as a client secret (or expects a cert/assertion structure), so passing an access token here will cause auth failures and the cached value will also expire without refresh. Consider implementing federated credentials as a proper client assertion (MSAL supports client assertions via client_credential), or if the intent is managed identity, return a ManagedIdentityClient like the existing managed identity auth types instead of wrapping it in a confidential client.

            elif self._msal_configuration.AUTH_TYPE == AuthTypes.federated_credentials:
                assert self._msal_configuration.FEDERATED_CLIENT_ID
                mi_client = ManagedIdentityClient(
                    SystemAssignedManagedIdentity(), # TODO
                    http_client=Session(),
                )
                mi_token = mi_client.acquire_token_for_client(resource=self._msal_configuration.FEDERATED_CLIENT_ID)
                if "access_token" not in mi_token:
                    logger.error(
                        f"Failed to acquire token for federated credentials: {mi_token}"
                    )
                    raise ValueError(
                        authentication_errors.FailedToAcquireToken.format(str(mi_token))
                    )
                self._client_credential_cache = mi_token["access_token"]
            else:
                logger.error(
                    f"Unsupported authentication type: {self._msal_configuration.AUTH_TYPE}"
                )
                raise NotImplementedError(
                    str(authentication_errors.AuthenticationTypeNotSupported)
                )

            return ConfidentialClientApplication(
                client_id=self._msal_configuration.CLIENT_ID,
                authority=authority,
                client_credential=self._client_credential_cache,
            )

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Using assert self._msal_configuration.FEDERATED_CLIENT_ID for runtime configuration validation is unsafe because asserts can be stripped with Python optimization flags, leading to harder-to-debug failures later. Please replace this with an explicit exception (e.g., ValueError) that clearly explains which configuration field is missing.

Suggested change

	assert self._msal_configuration.FEDERATED_CLIENT_ID
	mi_client = ManagedIdentityClient(
	SystemAssignedManagedIdentity(), # TODO
	if not self._msal_configuration.FEDERATED_CLIENT_ID:
	raise ValueError(
	"Missing MSAL configuration field 'FEDERATED_CLIENT_ID' "
	"required for 'federated_credentials' authentication type."
	)
	mi_client = ManagedIdentityClient(
	SystemAssignedManagedIdentity(), # TODO

[Copilot]

This new auth type introduces new behavior in _create_client_application, but there are existing pytest suites for MsalAuth and tenant resolution. Please add tests that cover the AuthTypes.federated_credentials branch (including failure paths when token acquisition fails), so regressions are caught early.

[Copilot]

AgentAuthConfiguration adds FEDERATED_CLIENT_ID, but the constructor doesn’t accept a corresponding explicit parameter (it’s only set via kwargs). For API consistency with the other fields (e.g., client_id, tenant_id, authority, etc.) and to match the PR description, add a federated_client_id: Optional[str] = None parameter and set self.FEDERATED_CLIENT_ID = federated_client_id or kwargs.get("FEDERATEDCLIENTID").