Mock get_token_scope in test_create_connector_client_normal_no_scopes #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opes Co-authored-by: MattB-msft <10568244+MattB-msft@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on get_token_scope method
Mock get_token_scope in test_create_connector_client_normal_no_scopes
Jan 18, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_create_connector_client_normal_no_scopestest was mockingClaimsIdentitywithout configuring theget_token_scope()method, which is called whenscopesisNoneinRestChannelServiceClientFactory.create_connector_client().Changes
claims_identity.get_token_scope()to return[f"{audience}/.default"]intest_create_connector_client_normal_no_scopesThis ensures the mock behaves consistently with the actual
ClaimsIdentity.get_token_scope()implementation when the factory invokesscopes or claims_identity.get_token_scope().✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.