Repository navigation
AgentApplication route selector changes - #240
Merged
tracyboehrer (tracyboehrer) merged 2 commits intoMay 2, 2025
Merged
Conversation
tracyboehrer (tracyboehrer)
enabled auto-merge
May 1, 2025 17:27
github-actions
Bot
added
ML: Core
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the route selector logic in AgentApplication and its corresponding tests in order to address issue #238. The changes adjust text matching for message activities and event routing for improved consistency.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tests/Microsoft.Agents.Builder.Tests/App/ApplicationRouteTests.cs | Updated tests for verifying route selection changes with string, regex and multiple selectors. |
| src/libraries/Builder/Microsoft.Agents.Builder/App/AgentApplication.cs | Modified route selectors to use Activity.IsType and updated matching logic for text and event name handling. |
Comments suppressed due to low confidence (1)
src/libraries/Builder/Microsoft.Agents.Builder/App/AgentApplication.cs:450
- Switching event name matching from checking Activity.Text to Activity.Name clarifies event routing. Please ensure that all event producers correctly set the Activity.Name property so that behavior remains consistent.
&& context.Activity.Name.Equals(eventName, StringComparison.OrdinalIgnoreCase)
MattB (MattB-msft)
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #238
Fixes #79