Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds integration tests for the OpenAI trace processor to validate observability functionality with real Azure OpenAI services. The tests verify that telemetry data is correctly captured and processed when using the OpenAI Agents SDK.
Key changes:
- New integration test suite for OpenAI trace processor with both basic and tool-based scenarios
- Test infrastructure setup with pytest fixtures for Azure OpenAI and Agent365 configuration
- CI workflow updates to separate unit and integration tests, with integration tests running conditionally based on available secrets
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/integration/test_openai_trace_processor.py | Adds comprehensive integration tests for OpenAI trace processor with mock span exporter and validation logic |
| tests/integration/conftest.py | Provides pytest fixtures for Azure OpenAI and Agent365 configuration with environment variable support |
| tests/integration/init.py | Initializes the integration tests package with proper copyright header |
| tests/.env.example | Documents the new AZURE_OPENAI_API_KEY environment variable requirement |
| pyproject.toml | Adds development dependencies and pytest configuration for unit and integration test markers |
| .github/workflows/ci.yml | Separates unit and integration test execution with conditional integration test runs |
juliomenendez
requested changes
Oct 30, 2025
juliomenendez
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task