Retrieve "additional_properties" from Entity#48
Merged
JesuTerraz merged 2 commits intomainfrom Nov 13, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to simplify model validation by using the base Entity type instead of specific subclasses (EmailReference and WpxComment). However, this introduces critical type safety and validation issues.
Key Changes:
- Removed the
payloadextraction logic that usedgetattr(ent, "properties", ent) - Changed validation from
EmailReference.model_validate(payload)toEntity.model_validate(ent) - Changed validation from
WpxComment.model_validate(payload)toEntity.model_validate(ent)
...a365-notifications/microsoft_agents_a365/notifications/models/agent_notification_activity.py
Show resolved
Hide resolved
...a365-notifications/microsoft_agents_a365/notifications/models/agent_notification_activity.py
Outdated
Show resolved
Hide resolved
...a365-notifications/microsoft_agents_a365/notifications/models/agent_notification_activity.py
Outdated
Show resolved
Hide resolved
joratz
previously approved these changes
Nov 13, 2025
JesuTerraz
changed the title
joratz
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.