fix: address code review comments for PR #149#150
Closed
pontemonti wants to merge 6 commits intousers/johanb/RTP_SemanticKernelfrom
Closed
fix: address code review comments for PR #149#150pontemonti wants to merge 6 commits intousers/johanb/RTP_SemanticKernelfrom
pontemonti wants to merge 6 commits intousers/johanb/RTP_SemanticKernelfrom
Conversation
Remove typing.Any and use sk.Kernel type for the kernel parameter in _validate_inputs method, adhering to project coding standards. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Improve exception logging security by logging generic error messages at ERROR level and detailed exception info at DEBUG level to avoid potential exposure of sensitive data from chat history. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use dataclasses.replace() to create a new ToolOptions instance instead of mutating the caller's object when orchestrator_name needs to be set. This avoids unexpected side effects for callers who reuse ToolOptions. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add test case LF-05 to verify that negative limit values are treated as no limit, sending all messages. This documents the expected behavior of the limit parameter when negative values are passed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add test case UV-07 to verify that when all input messages are filtered (empty content, whitespace, None), the core service is still called with an empty list. This ensures the user message registration still occurs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove unused sample_tool_message fixture from conftest.py. The fixture was defined but never used in any test. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
This was a test - not moving forward with these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses agent-resolvable code review comments from PR #149.
Comments Resolved
typing.Anyand usesk.Kerneltype for the kernel parameterdataclasses.replace()to avoid mutating the caller'sToolOptionsobjectsample_tool_messagefixtureReview File
See
.codereviews/claude-pr149-20260128_162006.mdfor full details.Tests
All 57 unit tests pass.
Generated with Claude Code