Skip to content

Fix test failure after adding event method to ILogger interface #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fpfp100 merged 2 commits into from
Feb 4, 2026
Merged

Fix test failure after adding event method to ILogger interface #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4e88c1
Initial plan
Copilot Feb 4, 2026
d4c743e
Fix test failure by adding event method to ILogger mocks
Copilot Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/agents-a365-observability/src/utils/logging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,10 @@ export function setLogger(customLogger: ILogger): void {
!customLogger ||
typeof customLogger.info !== 'function' ||
typeof customLogger.warn !== 'function' ||
typeof customLogger.error !== 'function'
typeof customLogger.error !== 'function' ||
typeof customLogger.event !== 'function'
) {
throw new Error('Custom logger must implement ILogger interface (info, warn, error methods)');
throw new Error('Custom logger must implement ILogger interface (info, warn, error, event methods)');
}
globalLogger = customLogger;
}
Expand Down
13 changes: 8 additions & 5 deletions tests/observability/core/custom-logger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,14 @@ describe('Custom Logger Support', () => {

describe('Global Logger Management', () => {
it('should set and get custom logger', () => {
const custom: ILogger = { info: jest.fn(), warn: jest.fn(), error: jest.fn() };
const custom: ILogger = { info: jest.fn(), warn: jest.fn(), error: jest.fn(), event: jest.fn() };

setLogger(custom);
expect(getLogger()).toBe(custom);
});

it('should reset to default logger', () => {
const custom: ILogger = { info: jest.fn(), warn: jest.fn(), error: jest.fn() };
const custom: ILogger = { info: jest.fn(), warn: jest.fn(), error: jest.fn(), event: jest.fn() };
setLogger(custom);

resetLogger();
Expand All @@ -111,7 +111,8 @@ describe('Custom Logger Support', () => {
const customLogger: ILogger = {
info: jest.fn(),
warn: jest.fn(),
error: jest.fn()
error: jest.fn(),
event: jest.fn()
};

setLogger(customLogger);
Expand All @@ -130,7 +131,8 @@ describe('Custom Logger Support', () => {
const selectiveLogger: ILogger = {
info: () => {},
warn: jest.fn(),
error: () => {}
error: () => {},
event: () => {}
};

setLogger(selectiveLogger);
Expand All @@ -149,7 +151,8 @@ describe('Custom Logger Support', () => {
const customLogger: ILogger = {
info: jest.fn(),
warn: jest.fn(),
error: jest.fn()
error: jest.fn(),
event: jest.fn()
};

new ObservabilityBuilder()
Expand Down