Skip to content

Conversation

@JesuTerraz
Copy link
Contributor

@JesuTerraz JesuTerraz commented Feb 3, 2026

Jesus Terrazas and others added 19 commits January 27, 2026 15:44
* Initial plan

* Address code review feedback: logging, validation, and documentation fixes

Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@JesuTerraz JesuTerraz changed the title Add CopilotStudio Permissions through develop add-permissions Support Custom Permissions through develop add-permissions Feb 10, 2026
@JesuTerraz JesuTerraz marked this pull request as ready for review February 10, 2026 19:43
@JesuTerraz JesuTerraz requested review from a team as code owners February 10, 2026 19:43
Copilot AI review requested due to automatic review settings February 10, 2026 19:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for targeting non-default resource APIs when using a365 develop add-permissions, aligning the command with the custom-resource support previously added to a365 develop get-token by centralizing resource keyword/ID resolution.

Changes:

  • Introduces ResourceResolutionHelper + ResolvedResource to resolve mcp/powerplatform keywords and custom resource GUIDs, with shared validation and error messages.
  • Extends develop add-permissions to accept --resource / --resource-id and routes both add-permissions and get-token through the shared resolver.
  • Adds unit tests for the new resolver and updates command tests; updates develop add-permissions documentation for the new resource support.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Microsoft.Agents.A365.DevTools.Cli/Helpers/ResourceResolutionHelper.cs New shared resource/keyword resolution + validation helper used by multiple commands.
src/Microsoft.Agents.A365.DevTools.Cli/Constants/ErrorMessages.cs Adds standardized error messages for resource resolution failures.
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/GetTokenSubcommand.cs Replaces local resource-resolution logic with ResourceResolutionHelper.
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs Adds --resource / --resource-id options and uses shared resource resolver.
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Helpers/ResourceResolutionHelperTests.cs New unit tests covering resource resolution behavior and error messaging.
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/AddPermissionsSubcommandTests.cs Updates command-option expectations for new resource options.
docs/commands/develop/develop-addpermissions.md Updates docs to describe multi-resource permission addition.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 10, 2026 19:50
JesuTerraz and others added 2 commits February 10, 2026 11:54
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Copilot AI review requested due to automatic review settings February 10, 2026 22:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Jesus Terrazas and others added 2 commits February 10, 2026 14:29
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings February 10, 2026 22:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Copy link
Contributor

@sellakumaran sellakumaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had an offline discussion with Jesus and shared comments.

Copilot AI review requested due to automatic review settings February 12, 2026 00:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants