-
Notifications
You must be signed in to change notification settings - Fork 8
Support Custom Permissions through develop add-permissions
#218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…sers/jterrazas/develop-add-permission-mcs
…sers/jterrazas/develop-add-permission-mcs
* Initial plan * Address code review feedback: logging, validation, and documentation fixes Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>
…hub.com/microsoft/Agent365-devTools into users/jterrazas/resource-flag-get-token
…rrazas/develop-add-permission-mcs
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
develop add-permissionsdevelop add-permissions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds support for targeting non-default resource APIs when using a365 develop add-permissions, aligning the command with the custom-resource support previously added to a365 develop get-token by centralizing resource keyword/ID resolution.
Changes:
- Introduces
ResourceResolutionHelper+ResolvedResourceto resolvemcp/powerplatformkeywords and custom resource GUIDs, with shared validation and error messages. - Extends
develop add-permissionsto accept--resource/--resource-idand routes bothadd-permissionsandget-tokenthrough the shared resolver. - Adds unit tests for the new resolver and updates command tests; updates
develop add-permissionsdocumentation for the new resource support.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Agents.A365.DevTools.Cli/Helpers/ResourceResolutionHelper.cs | New shared resource/keyword resolution + validation helper used by multiple commands. |
| src/Microsoft.Agents.A365.DevTools.Cli/Constants/ErrorMessages.cs | Adds standardized error messages for resource resolution failures. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/GetTokenSubcommand.cs | Replaces local resource-resolution logic with ResourceResolutionHelper. |
| src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs | Adds --resource / --resource-id options and uses shared resource resolver. |
| src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Helpers/ResourceResolutionHelperTests.cs | New unit tests covering resource resolution behavior and error messaging. |
| src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Commands/AddPermissionsSubcommandTests.cs | Updates command-option expectations for new resource options. |
| docs/commands/develop/develop-addpermissions.md | Updates docs to describe multi-resource permission addition. |
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Constants/ErrorMessages.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/GetTokenSubcommand.cs
Show resolved
Hide resolved
src/Tests/Microsoft.Agents.A365.DevTools.Cli.Tests/Helpers/ResourceResolutionHelperTests.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
src/Microsoft.Agents.A365.DevTools.Cli/Helpers/ResourceResolutionHelper.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/AddPermissionsSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Commands/DevelopSubcommands/GetTokenSubcommand.cs
Show resolved
Hide resolved
src/Microsoft.Agents.A365.DevTools.Cli/Helpers/ResourceResolutionHelper.cs
Outdated
Show resolved
Hide resolved
…github.com/microsoft/Agent365-devTools into users/jterrazas/develop-add-permission-mcs
sellakumaran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had an offline discussion with Jesus and shared comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
develop get-token#224 by merging similar logic for custom resources.