Split E2E in its own workflow for better management #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the E2E status update workflow by separating status collection from README updates. The JavaScript-based README update logic has been replaced with a Python script for better maintainability.
Changes:
- Split the monolithic "Get job statuses and update README" step into two separate steps: "Get job statuses" and "Update README"
- Replaced JavaScript file operations with a Python script using heredoc syntax for README updates
- Added step output propagation using
core.setOutput()and environment variables to pass data between steps - Simplified job status mapping by removing badge generation from the JavaScript step
…ring handling, textwrap.dedent, and job count tracking
abdulanu0
previously approved these changes
Jan 28, 2026
…ator - removes need for actions:write permission
…rocessId, remove invalid -OutputPath and -TestName parameters
…tification don't exist
rahuldevikar761
changed the title
pontemonti
approved these changes
Jan 30, 2026
abdulanu0
approved these changes
Jan 30, 2026
abdulanu0
pushed a commit
that referenced
this pull request
Jan 30, 2026
* fix: Correct YAML syntax in update-e2e-status workflow * fix: Apply Copilot review suggestions - proper URL encoding, empty string handling, textwrap.dedent, and job count tracking * Split into multiple workflows * refactor: Use workflow_call instead of workflow_dispatch for orchestrator - removes need for actions:write permission * fix: Correct PowerShell parameter names - use -AgentPID instead of -ProcessId, remove invalid -OutputPath and -TestName parameters * fix: Remove invalid test filter - test names BasicConversation and Notification don't exist * chore: Remove deprecated monolithic E2E workflow * chore: Remove deprecated monolithic E2E workflow
abdulanu0
added a commit
that referenced
this pull request
Jan 30, 2026
* Add Claude and LangChain samples to E2E workflow - Add nodejs-claude, python-claude, and nodejs-langchain jobs - Add SDK version logging for all samples (Get-SDKVersions.ps1) - Add prettified test conversation output (Emit-TestConversations.ps1) - Add PR comment with test summary (skips manual/scheduled runs) - Update summary job to include all 7 samples with status icons - Add pull-requests: write permission for PR comments * fix(e2e): Fix PowerShell variable parsing in Emit-TestConversations.ps1 Use \ instead of \ * fix(e2e): Add agentic_scopes to nodejs-claude and nodejs-langchain jobs Required for AgenticAuthorization handler * Address PR review comments - Fix pipe character escaping in Emit-TestConversations.ps1 (use \\| instead of \|) - Fix Windows-specific path construction in Get-SDKVersions.ps1 (use nested Join-Path) - Fix package filtering to exclude A365 packages from Agents SDK list - Fix bash status icon syntax (use if-else instead of command substitution) * Remove Claude samples from E2E workflow * Use Node.js OpenAI secrets for LangChain sample * Fix LangChain sample: add health endpoint and read PORT from env * Update LangChain sample to support both Azure OpenAI and OpenAI - Add flexible model configuration that checks for Azure OpenAI first - Fall back to regular OpenAI if Azure credentials not present - Update .env.example with both options documented - Provides clear error message if no credentials found * Split E2E in its own workflow for better management (#198) * fix: Correct YAML syntax in update-e2e-status workflow * fix: Apply Copilot review suggestions - proper URL encoding, empty string handling, textwrap.dedent, and job count tracking * Split into multiple workflows * refactor: Use workflow_call instead of workflow_dispatch for orchestrator - removes need for actions:write permission * fix: Correct PowerShell parameter names - use -AgentPID instead of -ProcessId, remove invalid -OutputPath and -TestName parameters * fix: Remove invalid test filter - test names BasicConversation and Notification don't exist * chore: Remove deprecated monolithic E2E workflow * chore: Remove deprecated monolithic E2E workflow * Add E2E workflow enhancements - Add LangChain E2E workflow (e2e-nodejs-langchain.yml) - Add SDK version logging step to all E2E workflows - Add test conversation emission step to all E2E workflows - Add PR test summary comment to orchestrator (only on PR events) - Update orchestrator to include LangChain and add pull-requests: write permission * Fix YAML syntax error in e2e-orchestrator.yml - use array join for PR comment body * Add debug logging to PR comment step * Fix bot comment detection - use login name instead of type * Remove debug logging from PR comment step * Add logging to diagnose PR comment update issue --------- Co-authored-by: Rahul Devikar <rahuldevikar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.