-
Notifications
You must be signed in to change notification settings - Fork 19
Add Orchestrator ci to run other ci #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request introduces a CI orchestrator workflow that centralizes and coordinates the execution of existing CI workflows across the repository. The orchestrator detects changes in specific directories and conditionally triggers the appropriate workflows, providing a unified entry point for branch protection requirements.
Changes:
- Added a new CI orchestrator workflow that uses path filtering to detect changes and conditionally call existing workflows
- Updated 10 existing CI workflows to support
workflow_callandworkflow_dispatchtriggers for orchestrator integration - Added Microsoft copyright headers to 7 workflow files that were missing them
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/ci-orchestrator.yml | New orchestrator workflow with change detection, conditional job execution, and unified status reporting |
| .github/workflows/python-claude-sample.yml | Added copyright header and workflow_call/workflow_dispatch triggers |
| .github/workflows/ci-python-openai-sampleagent.yml | Added copyright header and workflow_call/workflow_dispatch triggers |
| .github/workflows/ci-python-googleadk-sampleagent.yml | Added copyright header and workflow_call/workflow_dispatch triggers |
| .github/workflows/ci-python-agentframework-sampleagent.yml | Added copyright header and workflow_call/workflow_dispatch triggers |
| .github/workflows/ci-nodejs-vercelsdk-sampleagent.yml | Added workflow_call/workflow_dispatch triggers (already had copyright header) |
| .github/workflows/ci-nodejs-openai-sampleagent.yml | Added workflow_call/workflow_dispatch triggers (already had copyright header) |
| .github/workflows/ci-nodejs-langchain-sampleagent.yml | Added workflow_call/workflow_dispatch triggers (already had copyright header) |
| .github/workflows/ci-nodejs-claude-sampleagent.yml | Added workflow_call/workflow_dispatch triggers (already had copyright header) |
| .github/workflows/ci-dotnet-semantickernel-sampleagent.yml | Added copyright header and workflow_call/workflow_dispatch triggers |
| .github/workflows/ci-dotnet-agentframework-sampleagent.yml | Added copyright header and workflow_call/workflow_dispatch triggers |
Comments suppressed due to low confidence (1)
.github/workflows/python-claude-sample.yml:12
- The python-claude-sample workflow is configured to trigger on branches [main, develop], which differs from all other workflows that use [main, master]. The orchestrator uses [main, master], meaning python-claude-sample will be called by the orchestrator for master branch changes (via workflow_call) but would not trigger directly on master. This creates inconsistent behavior. Consider standardizing all workflows to use the same branch configuration, or document why python-claude-sample needs different branch triggers.
branches:
- main
- develop
No description provided.