-
Notifications
You must be signed in to change notification settings - Fork 19
Using EmailResponse when responding to email notifications #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements proper EmailResponse entity wrapping for email notification responses across multiple agent samples in both Python and Node.js implementations. The changes ensure that when agents respond to email notifications, the responses are properly formatted using the EmailResponse entity type as required by the Agent 365 framework.
Key Changes
- Updated email notification handlers to use
createEmailResponseActivity()helper (Node.js) orEmailResponseentity wrapping (Python) for proper response formatting - Replaced placeholder notification handlers with complete email notification processing implementations that retrieve email content and generate appropriate responses
- Fixed spelling errors in notification messages ("Recieved" → "Received")
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| python/claude/sample-agent/host_agent_server.py | Added EmailResponse entity wrapping for email notification responses with conditional check for notification type |
| nodejs/vercel-sdk/sample-agent/src/agent.ts | Implemented full email notification handler using createEmailResponseActivity with error handling |
| nodejs/perplexity/sample-agent/src/notificationService.ts | Replaced stream.sendFinal with createEmailResponseActivity for proper email response formatting |
| nodejs/openai/sample-agent/src/agent.ts | Implemented full email notification handler using createEmailResponseActivity with error handling |
| nodejs/n8n/sample-agent/src/n8nAgent.ts | Wrapped email response in createEmailResponseActivity entity |
| nodejs/langchain/sample-agent/src/agent.ts | Implemented full email notification handler using createEmailResponseActivity with error handling |
| nodejs/devin/sample-agent/src/agent.ts | Added complete agent notification handler with email-specific processing using createEmailResponseActivity |
| nodejs/claude/sample-agent/src/agent.ts | Implemented full email notification handler using createEmailResponseActivity with error handling |
No description provided.