Add @types/express dependency to allow Node.js Langchain sample build to work #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added CODEOWNERS * Added .gitignore --------- Co-authored-by: Johan Broberg <johanb@microsoft.com>
Co-authored-by: Johan Broberg <johanb@microsoft.com>
Co-authored-by: Johan Broberg <johanb@microsoft.com>
Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
Co-authored-by: Johan Broberg <johanb@microsoft.com>
Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* Adding Python Agent Framework Sample * update to latest --------- Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* Revise README for Agent 365 Sample Agent Updated the README to improve clarity and correct typos. Added sections on prerequisites, running the sample, and troubleshooting. * Update README to remove external sample reference Removed reference to the semantic-kernel-multiturn sample.
* update agents sdk version for langchain * Accept more recent versions * remove authority field, this is set by default --------- Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* Adding Notifications on AF * Update readme * PR comments * small fix * removed observability * update manifest * changes * setup fix
Added comprehensive instructions for GitHub Copilot to follow during code reviews, including rules for checking keywords, copyright headers, and Agent 365 sample validation.
* update with api change * update claude to tool service api name change * name change --------- Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* Add Vercel AI SDK sample * fix comments --------- Co-authored-by: Dominik Bezic <dominikbezic@microsoft.com>
* introducing perplexity sample agent * applying changes from code review * updated readme file with features list --------- Co-authored-by: aubreyquinn <aubreyquinn+odspmdb@microsoft.com>
* Add OpenAI Nodejs Sample * fix: model to string * Add copyright headers * Add build script * fix typo * fix typo in doc * take comments * update doc for env name change * update license path in readme * update walkthrough to follow same structure as AF * include agentsplayground in readme --------- Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
…ion (#31) * Initial plan * Rename "Microsoft Agents A365" to "Microsoft Agent 365" Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>
Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* add updated nodejs claude implementation * fix typos * change mcp endpoint to prod * review comments * add auth from agents-hosting * remove lock
* quickstart initial code * rename folder * update docs on quickstart * add links and update docs * include rename change * copilot suggestions --------- Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* Introducing playground notification handling in Perplexity agent * Introducing playground Teams messaging notification handling in Perplexity agent * applying changes from code review * Apply suggestion from @Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * applying changes from code review * Add missing copyright header to playgroundActivityTypes.ts (#36) * Initial plan * Add Microsoft copyright header to playgroundActivityTypes.ts Co-authored-by: aubreyquinn <80953505+aubreyquinn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aubreyquinn <80953505+aubreyquinn@users.noreply.github.com> * Add copyright header to playgroundActivityTypes.ts (#35) * Initial plan * Add Microsoft copyright header to playgroundActivityTypes.ts Co-authored-by: aubreyquinn <80953505+aubreyquinn@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: aubreyquinn <80953505+aubreyquinn@users.noreply.github.com> --------- Co-authored-by: aubreyquinn <aubreyquinn+odspmdb@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
* Cursor IDE prompt usage --------- Co-authored-by: shirahman <shirahman@microsoft.com>
* Update samples to remove environment id from calls and settings * remove env id from newer samples * Update python/agent-framework/sample-agent/.env.template Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Fix formatting of 'Microsoft Agent365' to 'Microsoft Agent 365' * Update README to reflect Microsoft Agent 365 SDK * Fix typo in Agent365 authentication comment * Fix comment formatting in client.ts Updated comments to improve clarity and consistency. * Fix typo in AGENT-TESTING.md * Fix description formatting in pyproject.toml * Update package description for clarity * Fix formatting of Agent 365 configuration comment * Update README to reference Microsoft Agent 365 SDK * Fix typo in Agent 365 Observability SDK comment * Update package description for clarity * Fix description formatting in pyproject.toml * Fix formatting in .env.template for Agent 365 * Update README.md * Update README.md * Fix naming in README for Agent Framework and SDK Updated README to correct naming conventions for Agent Framework and Microsoft Agent 365 SDK. * Update license link in README.md * Update perplexityClient.ts * Update README to reference Microsoft Agent 365 SDK * Fix typo in LangChain client documentation * Update README to reflect Microsoft Agent 365 SDK
Co-authored-by: shirahman <shirahman@microsoft.com>
…lity (#81) * Adding points for the users who contributed towards code review & quality * adding leaderboard.json * added permissions to the workflow * resolved comments --------- Co-authored-by: Lavanya Kappagantu <kalavany@microsoft.com>
* Add Agent Framework and Semantic Kernel enhancements Introduced a new .NET Agent Framework Sample Agent with CI/CD setup, OpenTelemetry observability, and tools for weather and date-time retrieval. Added ASP.NET authentication utilities and Teams app manifest. Updated Semantic Kernel Sample Agent with streaming support, enhanced observability, and plugins for terms and conditions handling. Included configuration files, README, and `.gitignore` for better project structure and documentation. * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Refactor async handling in HTTP operations Updated `InvokeObservedHttpOperation` to return `Task` for better async support and added `ConfigureAwait(false)` in `Program.cs` to prevent synchronization context capture. These changes improve performance, reliability, and adherence to async best practices. * Refactor to support async in HTTP operation handling Updated `Program.cs` to use `await` and `ConfigureAwait(false)` for `AgentMetrics.InvokeObservedHttpOperation` to ensure proper asynchronous execution. Modified `AgentMetrics.cs` to change `InvokeObservedHttpOperation` from `void` to `Task` return type, aligning with async programming practices. Updated the method to handle asynchronous operations and return `Task.CompletedTask` for consistency. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* adding authorization back to add tool servers call * remove auth config for agentsplayground connection * fixing claude sample * fix indentation * Add useJwtMiddleware if agent is hosted publicly * change useJwt to isProd * Namechange isProduction boolean --------- Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
* Creating a PR when the leaderboard needs to be updated * addressed comments --------- Co-authored-by: Lavanya Kappagantu <kalavany@microsoft.com>
* Add bug report issue template This file serves as a template for users to report bugs, detailing the necessary sections for a comprehensive bug report. * Add feature request issue template
* Create workflow for Vercel SDK sample agent * Add static authHandlerName to A365Agent class * Update .github/workflows/ci-nodejs-vercelsdk-sampleagent.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Remove npm cache configuration from CI workflow Removed caching configuration for npm in CI workflow. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
Co-authored-by: Dominik Bezic <dominikbezic@microsoft.com>
…le README (#108) * Initial plan * Fix broken SECURITY.md and LICENSE.md links in LangChain Node.js README Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pontemonti <7850950+pontemonti@users.noreply.github.com>
* Add contributing guidelines to CONTRIBUTING.md Added contributing guidelines to the project, including sections on code of conduct, how to contribute, development process, and licensing. * Update CONTRIBUTING.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update CONTRIBUTING.md Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Johan Broberg <johan@pontemonti.net> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the @types/express package as a dev dependency to the Node.js LangChain sample to resolve TypeScript build errors. The sample's src/index.ts file imports Express types (Express, Response) from the express module, which requires the corresponding type definitions package to compile successfully.
Key Changes:
- Adds
@types/expressversion 5.0.3 to devDependencies, matching the Express 5.1.0 runtime dependency
13 tasks
Josina20
force-pushed
the
users/johanb/FixNodeJsLangchainBuild
branch
from
35c96e7 to
344d80f
Compare
Contributor
Author
|
Resolved this through another PR - closing |
auto-merge was automatically disabled
January 22, 2026 19:02
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.