Make AdaptiveCards.Templating AOT compatible #8919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
approved these changes
Jun 25, 2024
Member
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8919 in repo microsoft/AdaptiveCards |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jwoo-msft
reviewed
Jun 25, 2024
jwoo-msft
approved these changes
Jun 26, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change moves AdaptiveCards.Templating to be built on System.Text.Json and the flavor of AdaptiveExpressions that also uses System.Text.Json. It was necessary to move off of Newtonsoft to be able to support AOT.
I have preserved the old API, but added AOT compatibility attributes and added AOT compatible versions instead. The AdaptiveCards.Templating library fundamentally works against json strings, and the APIs which took object would immediately serialize that object to a json string. The main changes are:
objectfrom the application now takestring, making it the caller's responsibility to serialize to json.object-based APIs remain for compatibility but are flagged asRequiresDynamicCodeandRequiresUnreferencedCode.How Verified
Ran all existing unit tests and they passed.
Note: I had to make one minor change to an expected test result because System.Text.Json does not round-trip literal double quotes in a string, they come back escaped not as
\"but as\u0022. It seems that Newtonsoft had different behavior around this.