Update how svg image file is being read#8893
Merged
Merged
Conversation
beervoley
reviewed
Apr 26, 2024
beervoley
approved these changes
Apr 26, 2024
Contributor
beervoley
left a comment
beervoley
left a comment
There was a problem hiding this comment.
Approved. @jwoo-msft will follow up to refactor this.
jwoo-msft
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#8892
Description
LoadFromUriAsync() gives a file not found error even if the file exists in WinUI3. Updated to read as string and parse into xml.
There is room for refactoring the SVG xml handling code.
Sample Card
Existing test: https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.5/Tests/Image.Svg.json
{ "type": "AdaptiveCard", "version": "1.6", "backgroundImage": { "url": "https://adaptivecards.io/content/Mostly%20Cloudy-Background.jpg" }, "body": [ { "type": "Image", "url": "https://dev.w3.org/SVG/tools/svgweb/samples/svg-files/car.svg", "size": "large" } ], "$schema": "http://adaptivecards.io/schemas/adaptive-card.json" }How Verified
Verified using the WinUI3 visualizer
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.5/Tests/Image.Svg.json
