Skip to content

[UWP Renderer] Title should be used as tooltip when tooltip is not provided #8232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 22, 2023
Merged

[UWP Renderer] Title should be used as tooltip when tooltip is not provided #8232

merged 8 commits into from
Feb 22, 2023

Conversation

anna-dingler
Copy link
Contributor

@anna-dingler anna-dingler commented Jan 17, 2023 •
edited
Loading

Related Issue

Fixes #8322

Description

Title should be used as the tooltip value if the tooltip property is not provided.

I added an additional check to set tooltip = title if tooltip.empty()

Sample Card

https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.5/Tests/TooltipTestCard.json

How Verified

Verified manually on the AdaptiveCards Visualizer.

Before

tooltip1

After

tooltip2

Microsoft Reviewers: Open in CodeFlow

anna-dingler and others added 5 commits December 16, 2022 00:41
@anna-dingler
Switch to gotFocus (#8148) (#8150)
1e0f72a
@jwoo-msft
Update custom.props
61db685
@anna-dingler @jwoo-msft
[UWP] Update custom.props for object model release (#8225)
0593d95 
* Update custom.props for object model release

* Updated Xcode version (#8222)

* removed build step as they are redundant (#8201)

* removed build step as they are redundant

* added pod installation step

Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
@anna-dingler @jwoo-msft
[UWP Renderer] Add a null check to inline action rendering (#8228)
90b97be 
* Update custom.props for object model release

* Updated Xcode version (#8222)

* removed build step as they are redundant (#8201)

* removed build step as they are redundant

* added pod installation step

* Add a null check for inline Actions

Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com>
@anna-dingler
Display title as tooltip
93e7e27
@ghost ghost added the no-recent-activity label Jan 22, 2023
@ghost
Copy link

ghost commented Jan 22, 2023

Hi @anna-dingler. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@anna-dingler anna-dingler changed the base branch from release/uwp-v3.1.0 to main February 21, 2023 23:45
@microsoft-github-policy-service
Copy link
Contributor

Staleness reset by anna-dingler

@anna-dingler anna-dingler merged commit 6c7d5eb into main Feb 22, 2023
@anna-dingler anna-dingler deleted the anna/updateActionTooltip branch February 22, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoo-msft jwoo-msft jwoo-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UWP Renderer] Title is not used as tooltip when tooltip is not present.
2 participants
@anna-dingler @jwoo-msft