Skip to content

[UWP] Fix crash when invoking show cards #4370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RebeccaAnne merged 3 commits into from
Jul 15, 2020
Merged

[UWP] Fix crash when invoking show cards #4370

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
893b9c2
[UWP] Fix crash when invoking show cards
Jul 13, 2020
40dc3ff
Merge branch 'feature/inputEvolution' into rebecch/showcardpopupbug
Jul 13, 2020
29b622a
Merge branch 'feature/inputEvolution' into rebecch/showcardpopupbug
Jul 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion source/uwp/Renderer/lib/RenderedAdaptiveCard.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,10 @@ namespace AdaptiveNamespace
{
return HandleInlineShowCardEvent(actionElement);
}
// else fallthrough
else
{
return m_actionEvents->InvokeAll(this, eventArgs.Get());
}
}
case ABI::AdaptiveCards::Rendering::Uwp::ActionType_Submit:
{
Expand All @@ -298,6 +301,10 @@ namespace AdaptiveNamespace
{
return S_OK;
}
else
{
return m_actionEvents->InvokeAll(this, eventArgs.Get());
}
}
case ABI::AdaptiveCards::Rendering::Uwp::ActionType_OpenUrl:
case ABI::AdaptiveCards::Rendering::Uwp::ActionType_Custom:
Expand Down