Skip to content

added '+' as a list marker for markdown #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jwoo-msft merged 1 commit into from
Jun 18, 2020
Merged

added '+' as a list marker for markdown #4194

jwoo-msft merged 1 commit into from
Jun 18, 2020

Conversation

@jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Jun 18, 2020 •
edited by ghost
Loading

Related Issue

Fixed #4117

Description

added '+' as a markdown list marker

How Verified

  1. Added new unit tests
  2. Ran all existing unit tests.
Microsoft Reviewers: Open in CodeFlow

shalinijoshi19
shalinijoshi19 approved these changes Jun 18, 2020
View reviewed changes
Copy link

@shalinijoshi19 shalinijoshi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shalinijoshi19
Copy link

shalinijoshi19 commented Jun 18, 2020

@matthidinger looks like CommonMark does support '+' as a valid list syntax (thanks to @jwoo-msft for digging it up) - https://spec.commonmark.org/0.29/#lists

@shalinijoshi19
Copy link

shalinijoshi19 commented Jun 18, 2020

@jwoo-msft could you ensure the .NET renderers also support all 3 syntax forms? Thanks

@jwoo-msft
Copy link
Member Author

jwoo-msft commented Jun 18, 2020

@jwoo-msft could you ensure the .NET renderers also support all 3 syntax forms? Thanks

I verified that .NET supports all 3 list markers.

@jwoo-msft jwoo-msft merged commit d1bddb3 into main Jun 18, 2020
@jwoo-msft jwoo-msft deleted the jwoo/markdown-plus-marker branch June 18, 2020 20:49
jwoo-msft added a commit that referenced this pull request Jul 7, 2020
@jwoo-msft
added '+' as a list marker for markdown (#4194)
a6eed97
jwoo-msft added a commit that referenced this pull request Jul 7, 2020
@jwoo-msft
Jwoo/release/1.2 (#4309)
6b640d2 
* added '*' as a list marker (#4175)

* added '+' as a list marker for markdown (#4194)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
@shalinijoshi19 shalinijoshi19 added this to the 20.06 milestone Jul 10, 2020
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
@jwoo-msft
added '+' as a list marker for markdown (microsoft#4194)
e12002f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shalinijoshi19 shalinijoshi19 shalinijoshi19 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

20.06

Development

Successfully merging this pull request may close these issues.

[Mobile][Markdown support] [Markdown with the * does not work on mobile renderers]

3 participants

@jwoo-msft @shalinijoshi19