-
Notifications
You must be signed in to change notification settings - Fork 593
Added MaxActions Limit Check #3696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1a84bf2
Added MaxActions limit check and replaced multiple of GetActions() call
jwoo-msft c217aba
Merge branch 'master' into jwoo/ios-hostconfig-fix
almedina-ms c5e5536
Merge branch 'master' into jwoo/ios-hostconfig-fix
3a53db9
added UnitTesting and Warning
jwoo-msft c6c060f
Merge branch 'jwoo/ios-hostconfig-fix' of github.com:Microsoft/Adapti…
jwoo-msft 2c2b536
added UnitTesting and Warning
jwoo-msft df5908e
Merge branch 'jwoo/ios-hostconfig-fix' of github.com:Microsoft/Adapti…
jwoo-msft 612ed58
Merge branch 'master' into jwoo/ios-hostconfig-fix
96bd9b1
Merge branch 'master' into jwoo/ios-hostconfig-fix
jwoo-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACOWarning.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // | ||
| // ACOWarning | ||
| // ACOWarning.h | ||
| // | ||
| // Copyright © 2020 Microsoft. All rights reserved. | ||
| // | ||
|
|
||
| #import "ACREnums.h" | ||
| #import <Foundation/Foundation.h> | ||
|
|
||
| @interface ACOWarning : NSObject | ||
|
|
||
| @property ACRWarningStatusCode statusCode; | ||
| @property NSString *message; | ||
|
|
||
| - (instancetype)initWith:(ACRWarningStatusCode)statusCode message:(NSString *)message; | ||
|
|
||
| @end |
28 changes: 28 additions & 0 deletions
28
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACOWarning.mm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| // | ||
| // ACOWarning | ||
| // ACOWarning.m | ||
| // | ||
| // Copyright © 2020 Microsoft. All rights reserved. | ||
| // | ||
|
|
||
| #import "ACOWarning.h" | ||
|
|
||
| @implementation ACOWarning | ||
|
|
||
| - (instancetype)init | ||
| { | ||
| return [self initWith:ACRUnknownElementType message:@""]; | ||
| } | ||
|
|
||
| - (instancetype)initWith:(ACRWarningStatusCode)statusCode message:(NSString *)message | ||
| { | ||
| self = [super init]; | ||
|
|
||
| if (self) { | ||
| _statusCode = statusCode; | ||
| _message = message; | ||
| } | ||
|
|
||
| return self; | ||
| } | ||
| @end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACREnums.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // | ||
| // ACREnums.h | ||
| // AdaptiveCards | ||
| // | ||
| // Copyright © 2020 Microsoft. All rights reserved. | ||
| // | ||
|
|
||
| #import <Foundation/Foundation.h> | ||
|
|
||
| typedef NS_ENUM(NSUInteger, ACRWarningStatusCode) { | ||
| ACRUnknownElementType = 0, | ||
| ACRUnknownActionElementType, | ||
| ACRUnknownPropertyOnElement, | ||
| ACRUnknownEnumValue, | ||
| ACRNoRendererForType, | ||
| ACRInteractivityNotSupported, | ||
| ACRMaxActionsExceeded, | ||
| ACRAssetLoadFailed, | ||
| ACRUnsupportedSchemaVersion, | ||
| ACRUnsupportedMediaType, | ||
| ACRInvalidMediaMix, | ||
| ACRInvalidColorFormat, | ||
| ACRInvalidDimensionSpecified, | ||
| ACRInvalidLanguage, | ||
| ACRInvalidValue, | ||
| ACRCustomWarning, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a warning if we have more than the max actions? Just checked and we do in UWP. #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with @RebeccaAnne here :)
In reply to: 363433129 [](ancestors = 363433129)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nesalang we should also have unit tests for this. #Resolved